feat(addon-mobile): add support for required option in sheet dialog #11327
Conversation
rashiddok
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
Failed tests ❌Before (main) ← Diff → After (local)textfield-disabled-select.cy.ts-tui-textfield-disabled.diff.png
(updated for commit 8ece0f9) |
rashiddok
force-pushed
the
feat/11082-tui-sheet-dialog-service
branch
from
c1331e0 to
b519384
Compare
|
View your CI Pipeline Execution ↗ for commit 8ece0f9
☁️ Nx Cloud last updated this comment at |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change -90B -0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
projects/addon-mobile/components/sheet-dialog/sheet-dialog.component.ts
Outdated
Show resolved
Hide resolved
rashiddok
force-pushed
the
feat/11082-tui-sheet-dialog-service
branch
from
1d35e52 to
b8d1ee3
Compare
| > | ||
| <p [style.flex-grow]="1"> | ||
| Karl Gambolputty de von | ||
| Ausfern-schplenden-schlitter-crasscrenbon-fried-digger-dingle-dangle-dongle-dungle-burstein-von-knacker-thrasher-apple-banger-horowitz-ticolensic-grander-knotty-spelltinkle-grandlich-grumblemeyer-spelterwasser-kurstlich-himbleeisen-bahnwagen-gutenabend-bitte-ein-nürnburger-bratwustle-gerspurten-mitzweimache-luber | ||
| von Hautkopft of Ulm was the last-surviving relative of Johann Gambolputty de von. | ||
| </p> | ||
| <footer tuiFloatingContainer> |
There was a problem hiding this comment.
Why remove tuiFloatingContainer?
There was a problem hiding this comment.
tuiFloatingContainer adds flex-direction: column that breaks buttons view
There was a problem hiding this comment.
returned tuiFloatingContainer directive and added styles for buttons container
There was a problem hiding this comment.
tuiFloatingContainer adds
flex-direction: columnthat breaks buttons view
Hmm... It looks like it's fine. Can you show me a screenshot/video, how does it break?
There was a problem hiding this comment.
It's fine until there is only one button. When more buttons added they take most of screen space and when dialog gets dissmised with swipe down buttons stays on place while dialog content goes behind buttons.
2025-07-24.09.20.19.mov
There was a problem hiding this comment.
When more buttons added they take most of screen space and when dialog gets dissmised with swipe down buttons stays on place while dialog content goes behind buttons.
When more buttons added It's designed to using only with 2 buttons max)
when dialog gets dissmised with swipe down buttons stays on place while dialog content goes behind buttons.
That's because it's based on sticky + and bottom. Would you prefer that when the SheetDialog is rolled down, the button immediately goes down too?
In result, I don't think it's worth abandoning the tuiFloatingContainer in the SheetDialog example or changing it
@waterplea, what do you think about such a case? Should we rework the logic of the tuiFloatingContainer, so that when scrolling down from the moment when the SheetDialog itself begins to collapse, the button would also go down?
splincode
force-pushed
the
feat/11082-tui-sheet-dialog-service
branch
from
a66117d to
8ece0f9
Compare
Description:
Closes #11082