Skip to content

ci: fix cypress problem #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: fix cypress problem #11422

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 08:46
@splincode splincode requested a review from a team as a code owner July 25, 2025 08:46
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team July 25, 2025 08:46
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 25, 2025 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title chore: fix cypress problem ci: fix cypress problem Jul 25, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d0e8bc8

Command Status Duration Result
nx component-test demo-cypress ✅ Succeeded 23m 23s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 6m 34s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 5m 2s View ↗
nx e2e demo-playwright -- --update-snapshots --... ✅ Succeeded 8m 26s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 3m 29s View ↗
nx e2e demo-playwright -- --update-snapshots --... ✅ Succeeded 6m 1s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 2m 41s View ↗
nx e2e demo-playwright -- --project=chromium --... ✅ Succeeded 2m 23s View ↗
Additional runs (13) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-25 11:47:17 UTC

Copilot
Copilot AI reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Cypress configuration and build issues in the demo-cypress project by updating TypeScript compilation settings, resolving import path problems, and optimizing font loading.

  • Updated TypeScript configuration to exclude .ts files from compilation
  • Fixed webpack compilation error by changing import path from @demo/utils to relative path
  • Reorganized HTML structure and improved font face declarations with proper weights

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
projects/demo-cypress/tsconfig.json Excludes TypeScript files from compilation to resolve build issues
projects/demo-cypress/src/tests/dropdown-mobile.cy.ts Replaces problematic import with direct relative path and adds explanatory comment
projects/demo-cypress/src/support/component-index.html Restructures HTML and adds multiple font-weight declarations for Manrope font
projects/demo-cypress/cypress.config.ts Adds webpack configuration and enables single tab run mode

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 25, 2025 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 347.42KB +10%
✅ demo/browser/vendor.(hash).js
 260.95KB +10%
✅ demo/browser/runtime.(hash).js
 52.52KB +10%
✅ demo/browser/styles.(hash).css
 21.38KB +10%
✅ demo/browser/polyfills.(hash).js
 11.16KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 9.55MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit d0e8bc8):

https://taiga-previews-demo--pr11422-splincode-cypress-problem-puu7fbfj.web.app

(expires Sat, 26 Jul 2025 11:09:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@splincode splincode force-pushed the splincode/cypress-problem branch from 72527fb to e1087ad Compare July 25, 2025 08:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Playwright test results

passed  1245 passed
skipped  3 skipped

Details

report  Open report ↗︎
stats  1248 tests across 77 suites
duration  13 minutes, 6 seconds
commit  d0e8bc8

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with legacy select
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

@splincode splincode force-pushed the splincode/cypress-problem branch from e1087ad to d81b7f5 Compare July 25, 2025 10:30
@splincode splincode force-pushed the splincode/cypress-problem branch from d81b7f5 to d0e8bc8 Compare July 25, 2025 11:08
@splincode splincode closed this Jul 26, 2025
@splincode splincode deleted the splincode/cypress-problem branch July 26, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mdlufy mdlufy mdlufy approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splincode @mdlufy