Skip to content

refactor(cdk): do not use EMPTY_QUERY in the future #11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(cdk): do not use EMPTY_QUERY in the future #11427

wants to merge 2 commits into from

Conversation

splincode
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 14:55
@splincode splincode requested a review from a team as a code owner July 25, 2025 14:55
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team July 25, 2025 14:55
@lumberjack-bot lumberjack-bot
Copy link

Tests are running 🚀

Wait for workflow run with tests to finish ☕

Copilot
Copilot AI reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a deprecation notice to the EMPTY_QUERY constant, indicating that developers should migrate to newer Angular APIs for better type safety.

  • Adds a deprecation annotation to EMPTY_QUERY constant recommending migration to modern Angular query APIs

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4d2e610

Command Status Duration Result
nx run-many --target test --all --output-style=... ✅ Succeeded 4m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-26 04:54:48 UTC

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 4d2e610):

https://taiga-previews-demo--pr11427-splincode-empty-demo-ol70x99k.web.app

(expires Sun, 27 Jul 2025 04:28:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 25, 2025 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 347.39KB +10%
✅ demo/browser/vendor.(hash).js
 260.83KB +10%
✅ demo/browser/runtime.(hash).js
 52.53KB +10%
✅ demo/browser/styles.(hash).css
 21.38KB +10%
✅ demo/browser/polyfills.(hash).js
 11.16KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 9.55MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Playwright test results

passed  1244 passed
flaky  1 flaky
skipped  3 skipped

Details

report  Open report ↗︎
stats  1248 tests across 77 suites
duration  20 minutes, 19 seconds
commit  4d2e610

Flaky tests

chromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay

Skipped tests

chromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with legacy select
chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

splincode and others added 2 commits July 26, 2025 07:23
mdlufy
mdlufy reviewed Jul 26, 2025
View reviewed changes
projects/cdk/constants/empty.ts
@@ -15,6 +15,7 @@ const rect = {
* For type safety when using @ContentChildren and @ViewChildren
*
* NOTE: Be careful subscribing to 'changes'
* @deprecated use viewChild(), viewChildren(), contentChild() and contentChildren() for strict type checking
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's problem with typing, provide negative example, please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

Copilot code review Copilot Copilot left review comments

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

At least 2 approving reviews are required to merge this pull request.

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splincode @mdlufy