Fix double emit sorting events when sorting by different key #11432
+138
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table sorting functionality was emitting multiple events when sorting by a different column, causing a "double emit" issue that could confuse developers and lead to unexpected behavior in applications.
Problem:
When sorting by a different column key, the
updateSorterAndDirection
method was calling bothupdateDirection(1)
andupdateSorter(sorter)
separately, which caused:directionChange
event to be emitted firstsorterChange
event to be emitted secondThis resulted in what users perceived as "double emit" of sorting events.
Solution:
Introduced atomic updates when sorting by a different key by:
updateSorterAndDirectionAtomically
that updates both internal state and emits events together in the same execution contextupdateSorterAndDirection
to use atomic updates for different keys while preserving existing behavior for same-key sorting (direction toggle)Changes:
TuiTableDirective.updateSorterAndDirection()
to handle different-key sorting atomicallyThe fix ensures that when sorting by a different column, both
directionChange
andsorterChange
events are emitted together in the same execution context, eliminating the perception of double emissions while maintaining full backward compatibility.Fixes #11420.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.nx.app
node /home/REDACTED/work/taiga-ui/taiga-ui/node_modules/.bin/nx run-many --target test --all --output-style=stream /tmp/test-double-emit.spec.ts --verbose
(dns block)/opt/hostedtoolcache/node/20.19.4/x64/bin/node /home/REDACTED/work/taiga-ui/taiga-ui/.nx/cache/cloud/2507.21.8/lib/heartbeat/heartbeat-process.js
(dns block)node /home/REDACTED/work/taiga-ui/taiga-ui/node_modules/.bin/nx run-many --target build --all --exclude=demo --output-style=stream --nxBail
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.