Editorial: wrap AC return values in completion records where needed #3601
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
added
editorial change
completion records
michaelficarra
force-pushed
the
AC-completion-records
branch
from
13b3d14 to
9193d0c
Compare
|
Rebased. |
bakkot
approved these changes
Jun 30, 2025
michaelficarra
added
the
ready to merge
ljharb
changed the title
ljharb
force-pushed
the
AC-completion-records
branch
from
9193d0c to
1b86903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there were 23. As discussed in editor call. Layered on top of #3599.