-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adjust invalid assertion about [[AsyncEvaluationOrder]] #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolo-ribaudo
wants to merge
3
commits into
tc39:main
Choose a base branch
from
nicolo-ribaudo:invalid-assertion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
guybedford
approved these changes
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It might be slightly more revealing to say is ~unset~
or ~done~
here to help understand the cases directly instead of via negation.
guybedford
approved these changes
Jun 20, 2025
linusg
approved these changes
Jun 26, 2025
michaelficarra
approved these changes
Jun 26, 2025
bakkot
reviewed
Jun 26, 2025
bakkot
approved these changes
Jun 27, 2025
|
(that's only up to the editors) |
And I'm not sure yet whether @syg will want to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly mistake by me in #3353, where I translated "[[AsyncEvaluation]] is false" to "[[AsyncEvaluationOrder]] is unset".
That's not true even in trivial cases. If you have module A that depends on module B, and B is async:
This is different from the error case, where we can indeed assert that [[AsyncEvaluationOrder]] is unset. That's because in the error case we perform the assertion on what's in the
stack
, but we push modules to it only after checking that they are not already evaluated.