Skip to content

Editorial: Reorder some TypedArray AOs to support top-down readability and future refactoring #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

gibson042
Copy link
Contributor

Split from #3629 as requested at #3629 (comment) , starting with AO reordering because internal movement is a big cause of avoidable merge conflicts.

@michaelficarra michaelficarra requested a review from a team June 27, 2025 19:22
@bakkot
Copy link
Contributor

bakkot commented Jun 30, 2025

LGTM once the assert is fixed.

@gibson042 gibson042 force-pushed the 3629-typedarray-ao-ordering branch from 706c645 to 863c536 Compare June 30, 2025 18:29
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jun 30, 2025
…TypedArray (tc39#3632)

The new [serendipitously alphabetical] ordering makes more obvious how
SetTypedArrayFromTypedArray is a specialized adaptation of
SetTypedArrayFromArrayLike when viewing the spec in top-to-bottom order.
@ljharb ljharb force-pushed the 3629-typedarray-ao-ordering branch from 863c536 to 60c4df0 Compare June 30, 2025 21:26
@ljharb ljharb merged commit 60c4df0 into tc39:main Jun 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants