Editorial: Make better use of ValidateTypedArray #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Jul 1, 2025
| @@ -41197,8 +41197,7 @@ <h1>%ArrayIteratorPrototype%.next ( )</h1> | |||
| 1. Let _index_ be _O_.[[ArrayLikeNextIndex]]. | |||
| 1. Let _kind_ be _O_.[[ArrayLikeIterationKind]]. | |||
| 1. If _array_ has a [[TypedArrayName]] internal slot, then | |||
| 1. Let _taRecord_ be MakeTypedArrayWithBufferWitnessRecord(_array_, ~seq-cst~). | |||
| 1. If IsTypedArrayOutOfBounds(_taRecord_) is *true*, throw a *TypeError* exception. | |||
| 1. Let _taRecord_ be ? ValidateTypedArray(_array_, ~seq-cst~). | |||
There was a problem hiding this comment.
This seems worse to me. Every existing use of ValidateTypedArray is passed an object which is not yet known to be a TA.
I'd be OK with introducing a new AO for this - GetInBoundsTALengthWitness or something, maybe - and then using it ValidateTypedArray and in callsites such as this. But I really don't like re-using ValidateTypedArray for this.
bakkot
reviewed
Jul 1, 2025
| 1. Else, | ||
| 1. Let _type_ be TypedArrayElementType(_typedArray_). | ||
| 1. If IsUnclampedIntegerElementType(_type_) is *false* and IsBigIntElementType(_type_) is *false*, throw a *TypeError* exception. | ||
| 1. Let _type_ be TypedArrayElementType(_typedArray_). |
There was a problem hiding this comment.
Why remove the else guard? There's no reason to do this check when _waitable_ is *true*, since it is implied by the checks in that branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #3629 as requested at #3629 (comment)