Use PreferDriver instead of PreferProtocol: #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API spec defines PreferredOrder to be the driver name not the protocol name. This causes the "gofish" provider to not change the order as that is the driver name not the protocol. The protocol is "redfish". Changing the implementation to use PreferDriver is chosen so as not to have to change the API spec validation. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 47.02% 47.02%
=======================================
Files 11 11
Lines 1361 1361
=======================================
Hits 640 640
Misses 664 664
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API spec defines PreferredOrder to be the driver name not the protocol name. This causes the "gofish" provider to not change the order as that is the driver name not the protocol. The protocol is "redfish". Changing the implementation to use PreferDriver is chosen so as not to have to change the API spec validation.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: