Skip to content

Update tinytag.py #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update tinytag.py #105

wants to merge 1 commit into from

Conversation

armsby
Copy link

@armsby armsby commented Feb 28, 2021

Added extra tags for audiobooks
Series this tag contains the series name
Series_number this tag contains the number in the series

Added extra tags for audiobooks
Series this tag contains the series name
Series_number this tag contains the number in the series
@devsnd
Copy link
Member

devsnd commented Aug 28, 2021

Hey @armsby,

I cannot merge your PR because it has failing tests. Please make sure that the tests run through, and I'll give it another look. Also, please add the series number and series to the extra field, by assigning them to e.g. extra.series_number instead of series_number. This removes the need to add any new attributes to the base TinyTag instance too.

@devsnd
Copy link
Member

devsnd commented Mar 12, 2022

I just wanted to port your patch to the newest version of tinytag, but apparently this is the "movement", like in classical music, and not the series/series number.

I also lack a test file to try this out, but once I have a test file, I can port your changes and add them to the extra fields.

@devsnd devsnd added enhancement missing sample file Cannot reproduce since the reporter did not upload a sample audio file labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement missing sample file Cannot reproduce since the reporter did not upload a sample audio file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants