session: deprecate options for spec. stream types #3893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
session/deprecate-stream-type-options
branch
2 times, most recently
from
85c9e09 to
2799909
Compare
back-to
approved these changes
Jul 31, 2021
Having multiple session options and CLI arguments for different stream
types which are already covered by generic options/arguments is not only
redundant, but also confusing.
A distinction between different stream types does only make sense when
multiple different stream types are available and the user needs to
explicitly set different values for each of them, but since it's not
always clear which stream type is returned when a stream is selected
via the "best" stream name synonym for example, this makes it even more
confusing. And it's redundant as well, since only one stream can be
selected anyway.
- deprecate `{dash,hds,hls}-segment-attempts`
in favor of `stream-segment-attempts`
- deprecate `{dash,hds,hls}-segment-threads`
in favor of `stream-segment-threads`
- deprecate `{dash,hds,hls}-segment-timeout`
in favor of `stream-segment-timeout`
- deprecate `{dash,hds,hls,rtmp,http-stream}-timeout`
in favor of `stream-timeout` (dash/http-stream were never used)
- fix `HTTPStream` and use `stream-timeout` instead of `http-timeout`
- suppress deprecated CLI arguments
- update help texts of generic CLI arguments
- fix docs and add entry to deprecations page
bastimeyer
force-pushed
the
session/deprecate-stream-type-options
branch
from
2799909 to
4405792
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Aug 1, 2021
…#3893) Having multiple session options and CLI arguments for different stream types which are already covered by generic options/arguments is not only redundant, but also confusing. A distinction between different stream types does only make sense when multiple different stream types are available and the user needs to explicitly set different values for each of them, but since it's not always clear which stream type is returned when a stream is selected via the "best" stream name synonym for example, this makes it even more confusing. And it's redundant as well, since only one stream can be selected anyway. - deprecate `{dash,hds,hls}-segment-attempts` in favor of `stream-segment-attempts` - deprecate `{dash,hds,hls}-segment-threads` in favor of `stream-segment-threads` - deprecate `{dash,hds,hls}-segment-timeout` in favor of `stream-segment-timeout` - deprecate `{dash,hds,hls,rtmp,http-stream}-timeout` in favor of `stream-timeout` (dash/http-stream were never used) - fix `HTTPStream` and use `stream-timeout` instead of `http-timeout` - suppress deprecated CLI arguments - update help texts of generic CLI arguments - fix docs and add entry to deprecations page
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multiple session options and CLI arguments for different stream
types which are already covered by generic options/arguments is not only
redundant, but also confusing.
A distinction between different stream types does only make sense when
multiple different stream types are available and the user needs to
explicitly set different values for each of them, but since it's not
always clear which stream type is returned when a stream is selected
via the "best" stream name synonym for example, this makes it even more
confusing. And it's redundant as well, since only one stream can be
selected anyway.
{dash,hds,hls}-segment-attemptsin favor of
stream-segment-attempts{dash,hds,hls}-segment-threadsin favor of
stream-segment-threads{dash,hds,hls}-segment-timeoutin favor of
stream-segment-timeout{dash,hds,hls,rtmp,http-stream}-timeoutin favor of
stream-timeout(dash/http-stream were never used)HTTPStreamand usestream-timeoutinstead ofhttp-timeouthls-segment-stream-datashould be removed as well and just set toTrue. In a separate PR.