Skip to content

[CWS] Sort replayed events #37845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

[CWS] Sort replayed events #37845

merged 1 commit into from
Jun 11, 2025

Conversation

Gui774ume
Copy link
Contributor

What does this PR do?

This PR sorts events that are replayed when a new ruleset is loaded (or on startup).

Motivation

This ensures that we evaluate execution events against our rule set in a consistent manner, regardless of how the execution was is captured (snapshot / runtime).

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@Gui774ume Gui774ume added this to the 7.68.0 milestone Jun 11, 2025
@Gui774ume Gui774ume requested a review from a team as a code owner June 11, 2025 09:03
@Gui774ume Gui774ume added component/system-probe team/agent-security qa/done QA done before merge and regressions are covered by tests labels Jun 11, 2025
@Gui774ume Gui774ume force-pushed the will/sort-replayed-events branch from 0c0df7a to 40e35a9 Compare June 11, 2025 09:05
paulcacheux
paulcacheux reviewed Jun 11, 2025
View reviewed changes
Base automatically changed from will/scope-field to main June 11, 2025 09:15
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jun 11, 2025
@Gui774ume Gui774ume force-pushed the will/sort-replayed-events branch from 40e35a9 to fdcc96a Compare June 11, 2025 09:20
@Gui774ume Gui774ume force-pushed the will/sort-replayed-events branch from fdcc96a to dab2a26 Compare June 11, 2025 09:21
@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-11 09:21:28 UTC ℹ️ Start processing command /merge

2025-06-11 09:21:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-11 11:31:04 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-11 12:12:00 UTC ℹ️ MergeQueue: This merge request was merged

@github-actions github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels Jun 11, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a6f57982-0452-4662-9181-e90eea5fb959

Baseline: a0635df
Comparison: dab2a26
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
✅ file_tree memory utilization -7.87 [-8.04, -7.70] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +3.31 [+0.25, +6.37] 1 Logs
➖ quality_gate_logs % cpu utilization +0.99 [-1.79, +3.77] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization +0.62 [+0.47, +0.78] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.36 [+0.29, +0.43] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.33 [+0.17, +0.50] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.26 [+0.20, +0.33] 1 Logs
➖ quality_gate_idle memory utilization +0.23 [+0.17, +0.30] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.15 [+0.02, +0.28] 1 Logs
➖ ddot_metrics memory utilization +0.12 [+0.01, +0.24] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.06 [-0.52, +0.65] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.06 [-0.55, +0.68] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.06 [-0.54, +0.66] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.57, +0.58] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.62, +0.63] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.27] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.59, +0.55] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.03 [-0.63, +0.57] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.05 [-0.28, +0.18] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.73 [-1.59, +0.13] 1 Logs
➖ ddot_logs memory utilization -0.74 [-0.88, -0.60] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.24 [-1.31, -1.18] 1 Logs
✅ file_tree memory utilization -7.87 [-8.04, -7.70] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ quality_gate_logs memory_usage 8/10 bounds checks dashboard
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 8/10 replicas passed. Failed 2 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 11, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 96e38c9

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.01}$$ $${696.07}$$ < $${752.99}$$ $${+0.04}$$ $${176.02}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0.01}$$ $${694.3}$$ < $${751.36}$$ $${+0}$$ $${175.48}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${+0.01}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${+0.01}$$ $${959.88}$$ < $${987.01}$$ $${+0}$$ $${146.44}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0.01}$$ $${696.06}$$ < $${752.98}$$ $${+0.03}$$ $${177.57}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0.01}$$ $${694.29}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${+0.01}$$ $${686.01}$$ < $${739.42}$$ $${+0.02}$$ $${161.03}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${684.35}$$ < $${737.91}$$ $${-0}$$ $${160.07}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0.01}$$ $${696.06}$$ < $${752.98}$$ $${+0.03}$$ $${177.57}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0.01}$$ $${694.29}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_suse_arm64 $${+0.01}$$ $${686.01}$$ < $${739.42}$$ $${+0.02}$$ $${161.03}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0}$$ $${684.35}$$ < $${737.91}$$ $${-0}$$ $${160.07}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0.01}$$ $${793.26}$$ < $${858.97}$$ $${+0.01}$$ $${255.99}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_jmx_arm64 $${+0.01}$$ $${793.26}$$ < $${858.97}$$ $${+0.01}$$ $${255.99}$$ < $${274.36}$$
✅ docker_agent_windows1809 $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows1809_core $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows1809_core_jmx $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows1809_jmx $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows2022 $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows2022_core $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows2022_core_jmx $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_agent_windows2022_jmx $${+0.01}$$ $${779.86}$$ < $${849.39}$$ $${+0.03}$$ $${268.62}$$ < $${288.34}$$
✅ docker_cluster_agent_amd64 $${+0.01}$$ $${259.2}$$ < $${259.73}$$ $${+0.01}$$ $${102.89}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0.06}$$ $${273.65}$$ < $${274.24}$$ $${-0.02}$$ $${97.59}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.03}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.98}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.49}$$ < $${60.17}$$ $${-0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.15}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${56.41}$$ $${-0}$$ $${11.21}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${-0}$$ $${11.16}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$

@dd-mergequeue dd-mergequeue bot merged commit 3884291 into main Jun 11, 2025
289 checks passed
@dd-mergequeue dd-mergequeue bot deleted the will/sort-replayed-events branch June 11, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikat spikat spikat approved these changes

@safchain safchain safchain approved these changes

@paulcacheux paulcacheux paulcacheux approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Gui774ume @spikat @safchain @paulcacheux