Make transactions inactive during clone #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asutherland - please take a look? |
asutherland
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Thanks! This is a great sanity-inducing invariant! (Or at least, not an insanity-inducing one, it may not be possible to induce sanity... :)
I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1598164 for us to implement. Since it's pretty low-hanging fruit and we've got more developer bandwidth in IDB currently, we're likely to get to it soon.
inexorabletash
force-pushed
the
txclone
branch
from
12e3013 to
0942443
Compare
inexorabletash
added a commit
that referenced
this pull request
Feb 1, 2021
To avoid side effects from getters during cloning operations (part of put/add/update calls), make transactions temporarily inactive. Implemented in Blink, pending implementation in Gecko.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid side effects from getters during cloning operations (part of put/add/update calls), make transactions temporarily inactive.
Implementation commitment:
Preview | Diff