Skip to content

remove reference to whitespace #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

remove reference to whitespace #135

merged 2 commits into from
Sep 15, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Aug 18, 2022

resolves #128

Per https://www.w3.org/2022/08/11-aria-minutes#t05, the WG resolved that the empty string should cause the attribute to be ignored, but not whitespace. So, reference to whitespace can be removed from this spec. However, referring to whitespace will remain in the ARIA spec and THERE it will link to the ascii-whitespace definition where applicable. Additionally, rather than a user agent requirement, it will become an authors requirement on not specifying whitespace as the value of an aria-roledescription


Preview | Diff

resolves #128

Per https://www.w3.org/2022/08/11-aria-minutes#t05, the WG resolved that the empty string should cause the attribute to be ignored, but not whitespace.  So, reference to whitespace can be removed from this spec.  However, referring to whitespace will remain in the ARIA spec and THERE it will link to the ascii-whitespace definition where applicable.   Additionally, rather than a user agent requirement, it will become an authors requirement on not specifying whitespace as the value of an aria-roledescription
@jnurthen
Copy link
Member

@jcsteh can you please review this.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, I'll do what ever we decide here for aria-brailleroledescription: https://github.com/w3c/core-aam/pull/134/files

@cookiecrook
Copy link
Contributor

cookiecrook commented Aug 25, 2022

From reading the IRC log, I'm somewhat surprised the WG agreed to allow authors to suppress the role description, but I acknowledge Aaron made a good point that the more complicated the logic is, the slower the implementations will be, and the more confused the authors will be. This is simpler, and allows a legitimate technique that is sometimes necessary (even if it can also be a footgun).

@jcsteh
Copy link

jcsteh commented Sep 15, 2022

My understanding of this is that aria-roledescription="" will not be exposed to AT.

First, why do we explicitly handle an empty attribute at all? Is this just "easy repair" for authoring error (as opposed to checking for white space, which would complicate the browser implementations)?

Second, @cookiecrook's comment makes me worry that I'm misunderstanding something here:

I'm somewhat surprised the WG agreed to allow authors to suppress the role description
...
allows a legitimate technique that is sometimes necessary (even if it can also be a footgun).

What do you mean by "suppress the role description" here? Are you referring to aria-roledescription="" or something else? What legitimate technique does this allow?

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 15, 2022

@jcsteh "suppress the role description" is in reference to Scott's comment at the top, and from digging through the linked minutes:

Per https://www.w3.org/2022/08/11-aria-minutes#t05, the WG resolved that the empty string should cause the attribute to be ignored, but not whitespace.

I was not in that conversation, so I may be mistaken, but if I understand correctly, you are correct that aria-roledescription="" (empty string) would be ignored but aria-roledescription=" " (with a non-empty whitespace value) would not be, effectively allowing an author to provide a blank role description. Similarly aria-brailleroledescription="⠀" (braille dots-0)

Copy link

@jcsteh jcsteh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cookiecrook. My understanding appears to be correct then.

This looks fine to me. I'm not sure how worthwhile it is to explicitly support the empty string; it seems like a very obvious and easy to explain authoring error. That said, it's easy to implement and I have no real objection to it.

@spectranaut spectranaut merged commit fbad1bd into main Sep 15, 2022
github-actions bot added a commit that referenced this pull request Sep 15, 2022
SHA: fbad1bd
Reason: push, by @spectranaut

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pkra pkra deleted the issue-128 branch September 16, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Whitespace characters" underspecified
5 participants