Move the entry point of the API to the window.navigator interface. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
approved these changes
Apr 29, 2021
beaufortfrancois
approved these changes
Apr 30, 2021
index.html
Outdated
| @@ -640,8 +640,8 @@ <h2> | |||
| <h3>Example 1: Posture data</h3> | |||
| <p>This is a simple use case of the <a>posture</a> being printed on the console. </p> | |||
| <pre class="example js" title="React to poster change"> | |||
| screen.posture.addEventListener("change", () => { | |||
| console.log(`The current posture is: ${screen.posture.type}!`); | |||
| window.navigator.devicePosture.addEventListener("change", () => { | |||
There was a problem hiding this comment.
Suggested change
| window.navigator.devicePosture.addEventListener("change", () => { | |
| navigator.devicePosture.addEventListener("change", () => { |
index.html
Outdated
| screen.posture.addEventListener("change", () => { | ||
| console.log(`The current posture is: ${screen.posture.type}!`); | ||
| window.navigator.devicePosture.addEventListener("change", () => { | ||
| console.log(`The current posture is: ${window.navigator.devicePosture.type}!`); |
There was a problem hiding this comment.
Suggested change
| console.log(`The current posture is: ${window.navigator.devicePosture.type}!`); | |
| console.log(`The current posture is "${navigator.devicePosture.type}".`); | |
darktears
force-pushed
the
screen-to-window-interface
branch
from
7c0a470 to
a3272e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
Preview | Diff