Skip to content

editorial: github contributors section #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

editorial: github contributors section #37

wants to merge 1 commit into from

Conversation

pkra
Copy link
Member

@pkra pkra commented Nov 10, 2023

Adds a new GH contributors section, matching other ARIA specs.

See w3c/aria-common#103 for more background.


Preview | Diff

Adds a new GH contributors section, matching other ARIA specs.

See w3c/aria-common#103 for more background.
@mattgarrish
Copy link
Member

These kinds of automated lists are a bit iffy in terms of relevance to the development of the document. The contribution could just be some technical detail of respec that needed fixing, such as W3C group name, licensing, etc. Meanwhile people who have made substantive suggestions in the comments but for which I opened the pull request, for example, get ignored (probably less an issue here than in dpub-aria, though). It also gets anyone in the history of the repository, so some of the names are for contributions six or seven years old that went into 1.0.

I'd probably be less hesitant if this were in a "Contributors" subsection and the lead-in sentence more clearly recognized that these are individuals who have opened pull requests. It still doesn't seem right to ignore commenters if we're going to add people who opened pull requests, but maybe we could add a generic sentence after acknowledging all commenters, too.

@pkra
Copy link
Member Author

pkra commented Dec 11, 2023

Thanks @mattgarrish.

Closing this as per discussion on today's editors call https://www.w3.org/2023/12/11-aria-editors-minutes.html

@pkra pkra closed this Dec 11, 2023
@mattgarrish mattgarrish deleted the contributors branch January 8, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants