Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Add support for uncancelable touch events #59

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

RByers
Copy link
Contributor

@RByers RByers commented Feb 20, 2016

Touch events (at least in Chrome and Safari) have long been marked cancelable=false during an active scroll, or after a touch event timeout has occurred. This updates the spec to reflect this.

This also adds text describing the relationship with passive event listeners.

Fixes #6

@RByers
Copy link
Contributor Author

RByers commented Feb 20, 2016

@smaug---- @dtapuska thoughts? This is a little hand-wavy, so I appreciate any suggestions for making the language more precise. But since this is all tied up in performance optimizations (whose details depend on the compositing / threaded input and hit-testing architecture of the user agent), we can't define exactly when a touch event will be cancelable.

Still I hope this is at least better than the long period where we've pretended that touch events can always be canceled. Sorry it's taken me so long to fix issue #6.

@patrickhlauke
Copy link
Member

LGTM

There's a long-standing issue (w3c#6) that the spec should allow touch events to be uncancelable during a scroll which cannot be interrupted.  I've tried to address that here while also adding specific text and a link about the implication of passive touch event listeners.  See the [passive event listeners explainer](https://github.com/RByers/EventListenerOptions/blob/gh-pages/explainer.md) for a high-level description of the problem being addressed.
@RByers
Copy link
Contributor Author

RByers commented Feb 23, 2016

Thanks Patrick! I made a couple minor improvements to the wording, and rebased and squashed. Preview here.

@smaug---- any suggestions?

@RByers
Copy link
Contributor Author

RByers commented Feb 24, 2016

Not hearing any complaints, I'll land this for now, happy to improve on it further in later CLs if people have suggestions.

RByers added a commit that referenced this pull request Feb 24, 2016
Add support for uncancelable touch events
@RByers RByers merged commit 74ecb02 into w3c:gh-pages Feb 24, 2016
@RByers RByers deleted the uncancelable branch February 24, 2016 23:12
@smaug----
Copy link

Sorry, I have tons of stuff to review, so I'm late with everything.

Looks ok.

@RByers
Copy link
Contributor Author

RByers commented Feb 25, 2016

No worries, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants