-
Notifications
You must be signed in to change notification settings - Fork 296
3.1.2 Language of Parts - Computed acc name clarification + ambiguous example #4423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giacomo-petri
wants to merge
6
commits into
main
Choose a base branch
from
giacomo-petri-patch-312-lang-of-parts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
13024ba
Update language-of-parts.html
giacomo-petri c43c4ab
removed redundancy
giacomo-petri 5ee62bb
missing example
giacomo-petri 299d9a6
html adjustment
giacomo-petri b73f4f7
Update language-of-parts.html
giacomo-petri b37038a
Update language-of-parts.html
giacomo-petri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
html adjustment
- Loading branch information
commit 299d9a6aaf3265887c207dc2fad4be4f52d2a78b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd preface this section with a preamble about the limitation of current assistive technologies in handling changes of language as part of their accessible name calculation. Explaining that while theoretically correct, switching language inside the accname is not currently supported. This then leads into the first example as simple mitigation.
Would be interested to know if this issue just happens in forms mode or also in browse mode? Does it also affect accessible description? Any other scenarios?
in the second example, you're technically not "setting" the parent element to the primary language ... you're letting it inherit the language from the document's overall language. and it's perhaps not that this is "acceptable", but rather that it's still required to do so (but being aware that AT may not switch language when announcing the link).