Fix not using localized formats in human_readable_date template tag
#13219
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebCorbin
changed the title
human_readable_date template tag
There was a problem hiding this comment.
Pull Request Overview
This PR updates the human_readable_date template tag to use Django’s localized date and datetime formats instead of the raw settings values.
- Imported
get_formatfromdjango.utils.formats - Replaced direct
settings.DATETIME_FORMATandsettings.DATE_FORMATlookups withget_format(... ) or fallback - Maintains existing fallback patterns if no localized format is defined
Comments suppressed due to low confidence (2)
wagtail/admin/templatetags/wagtailadmin_tags.py:1355
- Add unit tests to verify that
human_readable_datecorrectly falls back to the default format and uses locale-specific formats returned byget_format.
tooltip_format = get_format("DATETIME_FORMAT") or "N j, Y, P"
wagtail/admin/templatetags/wagtailadmin_tags.py:1353
- [nitpick] Consider adding a short docstring for
human_readable_dateto explain its behavior with localized formats and fallback logic.
def human_readable_date(date, description=None, placement="top"):
lb-
added
component:UI localization
- Ensure the `human_readable_date` template tag, the formats are not taken directly from django.conf.settings. - Instead, use instead the format localization getter `django.utils.formats.get_format`. - Fixes wagtail#13217
lb-
approved these changes
Jul 13, 2025
lb-
force-pushed
the
13217-human_readable_date-should-use-localized-formats
branch
from
60f832d to
94d7987
Compare
SebCorbin
deleted the
13217-human_readable_date-should-use-localized-formats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
human_readable_dateshould use localized formats #13217