Reland "Prerender: Add WPTs for prerendering for URLs with fragments" #41174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 25, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4716019
branch
2 times, most recently
from
ee988f9 to
27c3093
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4716019
branch
3 times, most recently
from
3abbd33 to
aaa6934
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4716019
branch
from
aaa6934 to
0aa2f17
Compare
This is a reland of commit e4a8214765c98b0791f183905dd7eeb63be499a1 Fix the main cause of flakiness (The arrival order of postMessage is non deterministic). Please see the diff of ps2 and ps3. Original change's description: > Prerender: Add WPTs for prerendering for URLs with fragments > > This CL adds WPTs to test and clarify current behavior of speculation- > rules triggered prerendering for URLs with fragments: > - If each URL specified for prerender are not completely identical, it > will be prerendered individually. Therefore, even if some URLs differ > only in fragments, they will be prerendered separately. > - The URL of the activated page should match the prerendering URL so > that they should contain the same fragments. > > Bug: 1417936 > Change-Id: I896709b25b26562919785b784a3d8b7f2bb384d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4478530 > Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Huanpo Lin <robertlin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1141291} Bug: 1417936 Change-Id: I312ab1c29ccf67af50c2ce811371ae89c74ec07c
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4716019
branch
from
0aa2f17 to
61e8071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit e4a8214765c98b0791f183905dd7eeb63be499a1
Fix the main cause of flakiness (The arrival order of postMessage is
non deterministic).
Please see the diff of ps2 and ps3.
Original change's description:
Bug: 1417936
Change-Id: I312ab1c29ccf67af50c2ce811371ae89c74ec07c
Reviewed-on: https://chromium-review.googlesource.com/4716019
WPT-Export-Revision: d9bc1e571e02f487b65c540a78e5d074e794bce5