Skip to content

Add device posture-related commands to testdriver #45602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JuhaVainio
Copy link
Contributor

Spec PR: w3c/device-posture#141

This PR adds the required infrastructure to manipulate device posture from testdriver. The two new commands correspond to the two WebDriver extension commands added by the spec PR above.

Spec PR: w3c/device-posture#141

This PR adds the required infrastructure to manipulate device posture
from testdriver. The two new commands correspond to the two WebDriver
extension commands added by the spec PR above.
@JuhaVainio JuhaVainio requested a review from a team as a code owner April 8, 2024 08:56
@wpt-pr-bot wpt-pr-bot added docs infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run labels Apr 8, 2024
@sideshowbarker sideshowbarker removed their request for review April 8, 2024 09:32
@JuhaVainio JuhaVainio closed this Apr 10, 2024
@JuhaVainio JuhaVainio reopened this Apr 10, 2024
@JuhaVainio
Copy link
Contributor Author

Failing checks are not related to this change.

@rakuco
Copy link
Member

rakuco commented Apr 10, 2024

cc @foolip @past with your core hats as well as people who can merge this despite the seemingly unrelated CI failures.

@foolip
Copy link
Member

foolip commented Apr 10, 2024

Something is going on with /infrastructure/assumptions/ahem.html. I have pushed #28759 to see if that fails without any changes. Feel free to ping when that has finished if I don't check back here.

@foolip
Copy link
Member

foolip commented Apr 10, 2024

#28759 is also failing with "CRITICAL Max restarts exceeded". It's not about /infrastructure/assumptions/ahem.html, that was just a test left in the queue.

@past can your team help get this resolved so that this doesn't block unrelated PRs?

@past
Copy link
Member

past commented Apr 10, 2024

@KyleJu is on rotation this week. Can you please take a look?

@KyleJu KyleJu closed this Apr 10, 2024
@KyleJu KyleJu reopened this Apr 10, 2024
@KyleJu
Copy link
Contributor

KyleJu commented Apr 10, 2024

It appears to be a Chromedriver issue. It should pass after I triggered the retry.

@rakuco
Copy link
Member

rakuco commented Apr 11, 2024

Thank you all. @foolip and @past could also you take a look at the change itself now that CI is passing?

@JuhaVainio
Copy link
Contributor Author

Hey @foolip, @past and @web-platform-tests/wpt-core-team, friendly ping

Copy link
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@past past merged commit 1a6206c into web-platform-tests:master Apr 17, 2024
@JuhaVainio
Copy link
Contributor Author

@past @WeizhongX Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants