-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add device posture-related commands to testdriver #45602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device posture-related commands to testdriver #45602
Conversation
Spec PR: w3c/device-posture#141 This PR adds the required infrastructure to manipulate device posture from testdriver. The two new commands correspond to the two WebDriver extension commands added by the spec PR above.
Failing checks are not related to this change. |
Something is going on with /infrastructure/assumptions/ahem.html. I have pushed #28759 to see if that fails without any changes. Feel free to ping when that has finished if I don't check back here. |
@KyleJu is on rotation this week. Can you please take a look? |
It appears to be a Chromedriver issue. It should pass after I triggered the retry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
@past @WeizhongX Thanks for review! |
Spec PR: w3c/device-posture#141
This PR adds the required infrastructure to manipulate device posture from testdriver. The two new commands correspond to the two WebDriver extension commands added by the spec PR above.