Fix button type getter steps #11047
Merged
Fix button type getter steps #11047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons in the Auto state that are submit buttons now reflect to submit correctly
zcorpan
approved these changes
Feb 19, 2025
annevk
reviewed
Feb 20, 2025
annevk
reviewed
Feb 20, 2025
annevk
reviewed
Feb 20, 2025
annevk
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
I also moved the Assert up. Looks good to me now. Can you confirm it still looks good to you @lukewarlow?
zcorpan
approved these changes
Feb 20, 2025
|
I think we maybe both reordered it and it got confused it seems to be below the state var still but looks good to me |
|
Well it should be below the state variable initialization, because it uses that. But it doesn't have to be below the Auto state check. |
|
Ah apologies I was confusing the assert and the submit button check. |
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Feb 20, 2025
Corresponds to part of whatwg/html#9841 and then whatwg/html#11047 Adding `Auto` as a type state feels a little odd, as it's not an actual type allowed in HTML. However, it's the default state when the value is missing or invalid, which works out the same, as long as we never serialize "auto", which we don't.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Feb 21, 2025
Corresponds to part of whatwg/html#9841 and then whatwg/html#11047 Adding `Auto` as a type state feels a little odd, as it's not an actual type allowed in HTML. However, it's the default state when the value is missing or invalid, which works out the same, as long as we never serialize "auto", which we don't.
tcl3
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Feb 22, 2025
Corresponds to part of whatwg/html#9841 and then whatwg/html#11047 Adding `Auto` as a type state feels a little odd, as it's not an actual type allowed in HTML. However, it's the default state when the value is missing or invalid, which works out the same, as long as we never serialize "auto", which we don't.
F3n67u
pushed a commit
to F3n67u/ladybird
that referenced
this pull request
Mar 5, 2025
Corresponds to part of whatwg/html#9841 and then whatwg/html#11047 Adding `Auto` as a type state feels a little odd, as it's not an actual type allowed in HTML. However, it's the default state when the value is missing or invalid, which works out the same, as long as we never serialize "auto", which we don't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix button type getter steps
Buttons in the Auto state that are submit buttons now reflect to submit correctly
Fixes #11046
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )