-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add commandfor & command attributes to HTMLButtonElement #9841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
e1f3111
Add commandfor & command attributes to HTMLButtonElement
keithamus 672183f
fix indentation
keithamus e4e1c4b
s/and false otherwise/; otherwise false
keithamus a76843c
remove undeeded comma
keithamus f65b298
move state outside span
keithamus 4e07504
fix casing in state names
keithamus a128e7a
drop definitions for attributes mapping to idl definitions
keithamus 719899d
use correct terms for popover show/hide (not open/close)
keithamus 8afb669
more s/, then://
keithamus c43b2fc
fix indentation
keithamus eec15ad
reintroduce accidentally removed line break
keithamus 2196384
fixup broken definition for popover visibility state
keithamus 9c93cb2
make commandForElement properly reflect the commandfor attribute
keithamus 934d950
reintroduce the command attribute definition
keithamus bff3f10
type and simplify the various invoker command steps
keithamus 150eec8
reintroduce the commandfor attribute definition
keithamus e5a111c
drop attribute reflection and use bespoke algorithms for command mapping
keithamus f0f3902
attempt to re-define submit button behavior with command/commandfor
keithamus 7a1fe7d
expand command getter steps into a list, always return string
keithamus 871c076
expand type getter steps to ensure "submit" is only returned for vali…
keithamus 05890f8
remove duplicate statement
keithamus 9f60688
s/DOMString?/DOMString/
keithamus ec6514f
s/Submit/submit
keithamus a3e56e4
use then over commas
keithamus b13fc3f
simplify button type steps, avoiding redundant state checks
keithamus 0790c33
switch from or to and for not-submit-button clause
keithamus 74949fe
backlink dom#1328 to the CommandEvent source getter steps
keithamus 8779da9
revert eager line wrapping
keithamus 1166eb4
remove erroneous rebase artefact
keithamus aa804b6
properly close li
keithamus 729674c
fixup "; return" to ", then return"
keithamus 5a6e582
rephase examples to say "the following code shows"
keithamus 4757ab1
s/Issue/DOM Standard Issue/
keithamus 23dac08
add note for developers, explaining the concept of custom commands
keithamus 7d5fc66
fixup button activation steps to return early for Reset/Submit non-fo…
keithamus bba3085
apply issue note to event initialisation too
keithamus 8e2d7a6
re-word concept submit button states to include type content-attribut…
keithamus a3bbc4a
remove erroneous step from rebase
keithamus 4dbb892
add missing "not"
keithamus 21fefc6
reintroduce accidentally remove event target to popover activation step
keithamus 767c4c3
introduce the "custom" state on command attribute table
keithamus a033ef8
rename "valid custom command" to "custom command keyword"
keithamus 8e6b74e
drop redundant note
keithamus 8d2a17b
use Custom state instead of isCustom bool
keithamus 8e6ae5b
title case all states
keithamus d6536f1
drop redundant check
keithamus 25d8c9b
properly reference commandfor in code examples
keithamus eb62a52
remove uneccessary parens
keithamus 8621f0a
suggestions from recent code review
keithamus 44a398d
add definition to attr-button-command-custom
keithamus 0c1dd19
link to buttons and popovers in example
keithamus e47a66c
fix casing
keithamus c1c8f42
make "custom command keyword" consistent
keithamus 34e7de8
consitently use span for "custom command keyword"
keithamus b5c402a
use code not span
keithamus 8b6b4db
s/not false/true
keithamus 15142b8
simplify the show/hidepopover command steps
keithamus 397c490
f code
keithamus f07be5a
comma
keithamus 224c61d
s/is the .*state/is in the .*state
keithamus 0ce6b7e
more casing fixes
keithamus c71a1fb
link example commandfor attribute and dialog
keithamus 2cf379a
rework state & attribute value to be a snapshot
keithamus d2eb8df
redo title casing
keithamus 0a57503
remove accidental ofs
keithamus d02a649
rephrase "corresponding to" state values
keithamus 9aa7109
s/, return/, then return
keithamus 463df24
line wrapping pass
keithamus c37596b
address various issues
annevk 35849e7
CI found another place that got improved
annevk d27d514
fix implicit submit/commandfor button logic
keithamus 7d69572
Merge remote-tracking branch 'upstream/main' into add-invoke
keithamus 7c44d2b
sync changes from #10960
keithamus 09d1279
Merge remote-tracking branch 'upstream/main' into add-invoke
keithamus 3279166
ensure button submit state is submit only when command/commandfor are…
keithamus abb077c
Merge remote-tracking branch 'upstream/main' into add-invoke
keithamus 4d7388d
switch code to span
keithamus 9470347
accidentally a w
keithamus 73ed957
reword button's submit button prose to be closer to main
keithamus 79aecb9
lowercase the
keithamus e9dbd6c
properly wrap assert
keithamus 74c72bf
lowercase the
keithamus d5c9ed4
rename invokee to target
keithamus 40893c4
re-order command getter steps to allow for "keyword corresponding to"
keithamus 05194d8
add command/commandfor attributes to button element attribute index
keithamus cb6a2d3
introduce button auto state
keithamus 4f70118
s/span/code
keithamus d345eb5
s/toggle/show
keithamus acf7248
s/utilise/use
keithamus 1aa382f
rework exampkle to use portrait/landscape
keithamus 4a580e6
add a .
keithamus 467c30c
reduce a level of nesting in dialog invoker command steps
keithamus 055ab9b
rework algorithms to use command state over value
keithamus a605a9c
accidentally a </p>
keithamus 1b7c383
fix some accidental close tag errors
keithamus 8a14367
fix faulty hide popover definition
keithamus ed46d37
actually fix hide popover calls
keithamus 7467651
accidentally a not
keithamus e576e82
s/span/code
keithamus c592656
drop node argument from is valid invoker command steps
keithamus 73e89d0
type arguments to invoker command steps
keithamus 45a98b8
collapse show modal branch of dialog invoker steps
keithamus 955b070
type is valid invoker command steps
keithamus 1096559
accidentally a /
keithamus baaeaa0
add missing type
keithamus 3d67bb9
drop extra argument
keithamus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
drop extra argument
- Loading branch information
commit 3d67bb99f8d73a4dcfb7dca2b25de3b056c4ad2e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.