Skip to content

fix(Picker): emit scrollInto when pass through each option #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shenjingnan
Copy link
Contributor

@shenjingnan shenjingnan commented Feb 4, 2024

fix: #12457

🚧 Under Development!

Cases

  • should emit scrollInto when click option
  • should emit scrollInto when touch move picker

Effect

CleanShot.2024-02-04.at.21.27.49.mp4

Jobs

  • Implement effect
  • add demo
  • update readme
  • add test cases
  • improve code

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (989a90a) to head (8349a20).
Report is 410 commits behind head on main.

Files with missing lines Patch % Lines
packages/vant/src/picker/PickerColumn.tsx 76.19% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12621      +/-   ##
==========================================
- Coverage   89.79%   89.76%   -0.03%     
==========================================
  Files         257      257              
  Lines        6830     6851      +21     
  Branches     1657     1662       +5     
==========================================
+ Hits         6133     6150      +17     
+ Misses        373      372       -1     
- Partials      324      329       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] scroll-into 返回的currentOption并不准确
2 participants