fix(Field): set value of the input field when slot change causes an update #13559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13559 +/- ##
==========================================
+ Coverage 89.60% 89.75% +0.14%
==========================================
Files 257 257
Lines 7013 7045 +32
Branches 1736 1743 +7
==========================================
+ Hits 6284 6323 +39
+ Misses 384 381 -3
+ Partials 345 341 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keeplearning66
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #13492
The bug is caused by the slot change leading to an update, but the input field value is not set.
I listen to the update caused by the slot change through onUpdated and call updateValue to set the input field value.
I’m sorry, I’m not sure how to write a unit test for this scenario.