[AGENTRUN-310] Fix FIPS Agent status output #37594

misteriaud · 2025-06-03T10:19:16Z

What does this PR do?

This PR prevent from printing the FIPS Proxy status section when the status command is executed with the FIPS Agent.
The FIPS Proxy status should be printed only when:

fips.enabled config is set to true
the Agent is not FIPS Agent

Motivation

This PR fix a regression introduced in #36988

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

…S Agent

cit-pr-commenter · 2025-06-03T11:19:01Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f5e472b1-b151-42f4-a6dd-54bceb6b02c8

Baseline: f07a0ac
Comparison: a95babf
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+1.22	[-1.90, +4.33]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.49	[+0.45, +0.53]	1	Logs
➖	ddot_metrics	memory utilization	+0.48	[+0.37, +0.59]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.47	[+0.39, +0.55]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.45	[-0.43, +1.34]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.43	[+0.26, +0.60]	1	Logs
➖	quality_gate_idle	memory utilization	+0.28	[+0.23, +0.34]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.16	[+0.02, +0.30]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.10	[-0.02, +0.23]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.08	[-0.15, +0.32]	1	Logs
➖	file_tree	memory utilization	+0.03	[-0.10, +0.17]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.63, +0.70]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.65, +0.67]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.62, +0.63]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.00	[-2.75, +2.76]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.27, +0.28]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.62, +0.54]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.04	[-0.67, +0.59]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.06	[-0.66, +0.55]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.09	[-0.74, +0.55]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.38	[-0.43, -0.32]	1	Logs
➖	docker_containers_memory	memory utilization	-0.40	[-0.45, -0.34]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	docker_containers_memory	memory_usage	0/10
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-06-03T12:09:54Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f07a0ac

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${731.83}$$ < $${752.99}$$	$${+0.01}$$	$${181.33}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${730.11}$$ < $${751.36}$$	$${-0}$$	$${180.79}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${+0}$$	$${358.52}$$ < $${369.68}$$	$${-0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${0}$$	$${959.62}$$ < $${987.01}$$	$${+0.02}$$	$${146.43}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${+0}$$	$${731.81}$$ < $${752.98}$$	$${-0.06}$$	$${183.48}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${730.1}$$ < $${751.35}$$	$${-0.03}$$	$${183.65}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${-0}$$	$${719.21}$$ < $${739.42}$$	$${-0.02}$$	$${165.37}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${717.63}$$ < $${737.91}$$	$${+0.03}$$	$${164.75}$$ < $${170.22}$$
✅	agent_suse_amd64	$${+0}$$	$${731.81}$$ < $${752.98}$$	$${-0.06}$$	$${183.48}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${730.1}$$ < $${751.35}$$	$${-0.03}$$	$${183.65}$$ < $${189.81}$$
✅	agent_suse_arm64	$${-0}$$	$${719.21}$$ < $${739.42}$$	$${-0.02}$$	$${165.37}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${717.63}$$ < $${737.91}$$	$${+0.03}$$	$${164.75}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${826.45}$$ < $${858.97}$$	$${-0}$$	$${263.63}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${826.45}$$ < $${858.97}$$	$${-0}$$	$${263.63}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0}$$	$${815.61}$$ < $${849.39}$$	$${+0}$$	$${277.08}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${259.13}$$ < $${259.73}$$	$${-0}$$	$${102.85}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${273.57}$$ < $${274.24}$$	$${+0}$$	$${97.57}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.92}$$ < $${39.57}$$	$${+0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${-0}$$	$${13.97}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.6}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${+0}$$	$${6.98}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.6}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.6}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.44}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.9}$$ < $${56.94}$$	$${-0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.48}$$ < $${56.41}$$	$${-0.01}$$	$${11.19}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.44}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.9}$$ < $${56.94}$$	$${-0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.44}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$

buraizu

Left some minor feedback for style and consistency with other release notes

buraizu · 2025-06-04T16:14:19Z

releasenotes/notes/fix_fips_agent_status-ad9cf20c53bdec9e.yaml

+---
+fixes:
+  - |
+     Removed the FIPS Proxy status section from the agent status page when running the FIPS Agent. 


Suggested change

Removed the FIPS Proxy status section from the agent status page when running the FIPS Agent.

Remove the FIPS Proxy status section from the Agent status page when running the FIPS Agent.

@buraizu QQ: Since these are put into the release notes, would it make more sense for them to be past-tense?

@sgnn7 good question, thanks for following up. Release notes are generally kept in present tense to clearly indicate that the change is available in the current version. This is the pattern followed by most of our other release notes as well.

May be good to communicate this wider in the Agent group as we're a bit inconsistent on this https://github.com/DataDog/datadog-agent/releases 😅

misteriaud · 2025-06-10T08:59:56Z

/merge

dd-devflow · 2025-06-10T09:00:00Z

View all feedbacks in Devflow UI.

2025-06-10 09:00:00 UTC ℹ️ Start processing command /merge

2025-06-10 09:00:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-10 09:38:10 UTC ℹ️ MergeQueue: This merge request was merged

(cherry picked from commit 0b19806)

fix: the FIPS Proxy status was printed when fips.enabled: true OR FIP…

55cafbe

…S Agent

misteriaud requested a review from a team as a code owner June 3, 2025 10:19

misteriaud requested a review from rahulkaukuntla June 3, 2025 10:19

github-actions bot added team/agent-configuration short review PR is simple enough to be reviewed quickly labels Jun 3, 2025

misteriaud added backport/7.66.x Automatically create a backport PR to 7.66.x backport/7.67.x Automatically create a backport PR to 7.67.x labels Jun 3, 2025

rahulkaukuntla approved these changes Jun 3, 2025

View reviewed changes

misteriaud and others added 2 commits June 4, 2025 13:47

Merge branch 'main' into misteriaud/fix-fips-agent-status

c4ff0b1

adding releasenote

2931a93

misteriaud requested a review from a team as a code owner June 4, 2025 11:55

misteriaud added the qa/done QA done before merge and regressions are covered by tests label Jun 4, 2025

Merge branch 'main' into misteriaud/fix-fips-agent-status

042883d

buraizu reviewed Jun 4, 2025

View reviewed changes

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jun 4, 2025

fix releasenote

a95babf

buraizu approved these changes Jun 6, 2025

View reviewed changes

dd-mergequeue bot merged commit 0b19806 into main Jun 10, 2025
241 checks passed

dd-mergequeue bot deleted the misteriaud/fix-fips-agent-status branch June 10, 2025 09:38

github-actions bot added this to the 7.68.0 milestone Jun 10, 2025

agent-platform-auto-pr bot pushed a commit that referenced this pull request Jun 10, 2025

[AGENTRUN-310] Fix FIPS Agent status output (#37594)

1d85eea

(cherry picked from commit 0b19806)

agent-platform-auto-pr bot mentioned this pull request Jun 10, 2025

[Backport 7.66.x] [AGENTRUN-310] Fix FIPS Agent status output #37804

Open

agent-platform-auto-pr bot pushed a commit that referenced this pull request Jun 10, 2025

[AGENTRUN-310] Fix FIPS Agent status output (#37594)

daf87dc

(cherry picked from commit 0b19806)

agent-platform-auto-pr bot mentioned this pull request Jun 10, 2025

[Backport 7.67.x] [AGENTRUN-310] Fix FIPS Agent status output #37805

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AGENTRUN-310] Fix FIPS Agent status output #37594

[AGENTRUN-310] Fix FIPS Agent status output #37594

Uh oh!

misteriaud commented Jun 3, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Jun 3, 2025 •

edited

Loading

Fine details of change detection per experiment

Explanation

Uh oh!

agent-platform-auto-pr bot commented Jun 3, 2025 •

edited

Loading

Info

Uh oh!

buraizu left a comment

Uh oh!

buraizu Jun 4, 2025

Uh oh!

sgnn7 Jun 4, 2025

Uh oh!

buraizu Jun 6, 2025

Uh oh!

sgnn7 Jun 6, 2025

Uh oh!

misteriaud commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

	Removed the FIPS Proxy status section from the agent status page when running the FIPS Agent.
	Remove the FIPS Proxy status section from the Agent status page when running the FIPS Agent.

[AGENTRUN-310] Fix FIPS Agent status output #37594

[AGENTRUN-310] Fix FIPS Agent status output #37594

Uh oh!

Conversation

misteriaud commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

Uh oh!

cit-pr-commenter bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

buraizu left a comment

Choose a reason for hiding this comment

Uh oh!

buraizu Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

sgnn7 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

buraizu Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

sgnn7 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

misteriaud commented Jun 10, 2025

Uh oh!

dd-devflow bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

misteriaud commented Jun 3, 2025 •

edited

Loading

cit-pr-commenter bot commented Jun 3, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jun 3, 2025 •

edited

Loading

dd-devflow bot commented Jun 10, 2025 •

edited

Loading