Skip to content

[Backport 7.66.x] [AGENTRUN-310] Fix FIPS Agent status output #37804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.66.x
Choose a base branch
from
Open

[Backport 7.66.x] [AGENTRUN-310] Fix FIPS Agent status output #37804

wants to merge 1 commit into from

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

@agent-platform-auto-pr agent-platform-auto-pr bot commented Jun 10, 2025 •
edited by misteriaud
Loading

Backport 0b19806 from #37594.

What does this PR do?

This PR prevent from printing the FIPS Proxy status section when the status command is executed with the FIPS Agent.
The FIPS Proxy status should be printed only when:

  • fips.enabled config is set to true
  • the Agent is not FIPS Agent

Motivation

This PR fix a regression introduced in #36988

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner June 10, 2025 09:39
@agent-platform-auto-pr agent-platform-auto-pr bot added qa/done QA done before merge and regressions are covered by tests backport labels Jun 10, 2025
@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner June 10, 2025 09:39
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Jun 10, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=67361110 --os-family=ubuntu

Note: This applies to commit 1d85eea

@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 57743915bc9c36d1d439c78336c47f1676814d98

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.23MB ⚠️ 805.81MB 805.59MB 0.50MB
datadog-agent-x86_64-suse 0.23MB ⚠️ 805.81MB 805.59MB 0.50MB
datadog-agent-amd64-deb 0.22MB ⚠️ 796.87MB 796.65MB 0.50MB
datadog-agent-aarch64-rpm 0.19MB ⚠️ 795.65MB 795.46MB 0.50MB
datadog-agent-arm64-deb 0.18MB ⚠️ 786.73MB 786.54MB 0.50MB
datadog-heroku-agent-amd64-deb 0.06MB ⚠️ 440.74MB 440.68MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 30.09MB 30.09MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 60.82MB 60.82MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 58.13MB 58.12MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 60.90MB 60.89MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 60.90MB 60.89MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 58.20MB 58.19MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.26MB 31.26MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 31.34MB 31.34MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 31.34MB 31.34MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor Author

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 770.73 MiB 778.06 MiB 188.76 MiB 191.06 MiB
✅ static_quality_gate_agent_deb_amd64_fips 768.68 MiB 776.09 MiB 187.24 MiB 190.72 MiB
✅ static_quality_gate_agent_heroku_amd64 428.42 MiB 434.99 MiB 112.74 MiB 114.34 MiB
✅ static_quality_gate_agent_msi 959.39 MiB 978.45 MiB 148.15 MiB 151.65 MiB
✅ static_quality_gate_agent_rpm_amd64 770.76 MiB 778.06 MiB 189.5 MiB 193.42 MiB
✅ static_quality_gate_agent_rpm_amd64_fips 768.67 MiB 776.06 MiB 189.03 MiB 192.61 MiB
✅ static_quality_gate_agent_rpm_arm64 761.07 MiB 768.33 MiB 172.21 MiB 174.71 MiB
✅ static_quality_gate_agent_rpm_arm64_fips 759.18 MiB 766.55 MiB 171.08 MiB 173.92 MiB
✅ static_quality_gate_agent_suse_amd64 770.76 MiB 778.08 MiB 189.5 MiB 193.42 MiB
✅ static_quality_gate_agent_suse_amd64_fips 768.64 MiB 776.11 MiB 189.03 MiB 192.78 MiB
✅ static_quality_gate_agent_suse_arm64 761.07 MiB 768.31 MiB 172.21 MiB 174.71 MiB
✅ static_quality_gate_agent_suse_arm64_fips 759.18 MiB 766.5 MiB 171.08 MiB 173.92 MiB
✅ static_quality_gate_docker_agent_amd64 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_arm64 868.86 MiB 876.0 MiB 274.49 MiB 278.3 MiB
✅ static_quality_gate_docker_agent_jmx_amd64 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_jmx_arm64 868.86 MiB 876.63 MiB 274.49 MiB 278.4 MiB
✅ static_quality_gate_docker_agent_windows1809 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_core 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_core_jmx 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_jmx 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_core 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_core_jmx 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_jmx 855.28 MiB 862.5 MiB 287.86 MiB 292.0 MiB
✅ static_quality_gate_docker_cluster_agent_amd64 262.79 MiB 263.4 MiB 103.33 MiB 104.07 MiB
✅ static_quality_gate_docker_cluster_agent_arm64 278.73 MiB 279.38 MiB 98.2 MiB 98.95 MiB
✅ static_quality_gate_docker_cws_instrumentation_amd64 6.65 MiB 7.12 MiB 2.82 MiB 3.29 MiB
✅ static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
✅ static_quality_gate_docker_dogstatsd_amd64 38.04 MiB 46.39 MiB 14.67 MiB 17.78 MiB
✅ static_quality_gate_docker_dogstatsd_arm64 36.95 MiB 45.05 MiB 13.75 MiB 16.65 MiB
✅ static_quality_gate_dogstatsd_deb_amd64 29.89 MiB 38.4 MiB 7.91 MiB 10.26 MiB
✅ static_quality_gate_dogstatsd_deb_arm64 28.78 MiB 36.98 MiB 6.89 MiB 8.96 MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 29.89 MiB 38.4 MiB 7.92 MiB 10.27 MiB
✅ static_quality_gate_dogstatsd_suse_amd64 29.89 MiB 38.4 MiB 7.92 MiB 10.27 MiB
✅ static_quality_gate_iot_agent_deb_amd64 58.09 MiB 58.51 MiB 14.61 MiB 15.02 MiB
✅ static_quality_gate_iot_agent_deb_arm64 55.52 MiB 55.94 MiB 12.63 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_deb_armhf 54.22 MiB 54.32 MiB 12.62 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_rpm_amd64 58.09 MiB 58.51 MiB 14.63 MiB 15.04 MiB
✅ static_quality_gate_iot_agent_rpm_arm64 55.52 MiB 55.94 MiB 12.65 MiB 13.07 MiB
✅ static_quality_gate_iot_agent_suse_amd64 58.09 MiB 58.51 MiB 14.63 MiB 15.04 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcretzman michaelcretzman michaelcretzman approved these changes

@rahulkaukuntla rahulkaukuntla rahulkaukuntla approved these changes

Assignees
No one assigned
Labels
backport bot qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelcretzman @rahulkaukuntla @misteriaud