Skip to content

[AMCC-11] dogstatsd: additional metric control mechanism between the sampler and the serializer #37692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 10, 2025

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Jun 5, 2025

What does this PR do?

Adds an additional processing step when the time samplers is flushing data to the serializer for serialization.
This extra step is necessary since the aggregation from the time sampler might possibly generate new metrics, that would not have been correctly visible to the metric control implementation which is running in the listening part of DogStatsD.

This implementation creates a sublist in order to avoid having to do a complete second pass with the configured list. This sublist contain only the metrics names generated from histograms, a heuristic try to do this using a static list of histogram aggregates and percentile suffixes.

Describe how you validated your changes

Manual tested E2E on an org with the feature enabled, also, will be extensively dogfooded.

remeh added 2 commits June 5, 2025 16:42
…he flush to the serializer.

This is to filter out metric names generated at the aggregation stage, in this
case the histogram aggregates.
@remeh remeh requested review from a team as code owners June 5, 2025 14:52
@remeh remeh requested a review from pgimalac June 5, 2025 14:52
@remeh remeh added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jun 5, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jun 5, 2025
Copy link

cit-pr-commenter bot commented Jun 5, 2025

Go Package Import Differences

Baseline: cbd7198
Comparison: 17feff2

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
dogstatsdlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
dogstatsdlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
serverlesslinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings
serverlesslinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/util/strings

Copy link

cit-pr-commenter bot commented Jun 5, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3280fd8f-7ef8-4538-9a90-4a265c7f6bdc

Baseline: cbd7198
Comparison: 17feff2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.51 [+0.44, +0.57] 1 Logs
quality_gate_logs % cpu utilization +0.40 [-2.34, +3.14] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.32 [+0.16, +0.49] 1 Logs
quality_gate_idle_all_features memory utilization +0.32 [+0.24, +0.39] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.27 [+0.23, +0.31] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.12 [-0.52, +0.75] 1 Logs
ddot_logs memory utilization +0.11 [-0.03, +0.26] 1 Logs
ddot_metrics memory utilization +0.09 [-0.02, +0.21] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.08 [-0.50, +0.66] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.05 [-0.18, +0.28] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.57, +0.64] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.58, +0.62] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.62] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.29, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.64, +0.61] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.10 [-0.68, +0.48] 1 Logs
quality_gate_idle memory utilization -0.28 [-0.34, -0.22] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.74 [-0.81, -0.66] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.84 [-1.74, +0.05] 1 Logs
otlp_ingest_logs memory utilization -0.87 [-1.00, -0.74] 1 Logs
docker_containers_cpu % cpu utilization -2.79 [-5.84, +0.25] 1 Logs
file_tree memory utilization -4.58 [-4.78, -4.39] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 5, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cbd7198

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${696.04}$$ < $${752.99}$$ $${+0.04}$$ $${176.06}$$ < $${187.44}$$
agent_deb_amd64_fips $${+0.01}$$ $${694.27}$$ < $${751.36}$$ $${+0.02}$$ $${175.48}$$ < $${187.06}$$
agent_heroku_amd64 $${+0}$$ $${358.56}$$ < $${369.68}$$ $${+0}$$ $${96.5}$$ < $${99.55}$$
agent_msi $${+0.02}$$ $${959.87}$$ < $${987.01}$$ $${+0.02}$$ $${146.45}$$ < $${150.72}$$
agent_rpm_amd64 $${+0}$$ $${696.03}$$ < $${752.98}$$ $${+0.06}$$ $${177.55}$$ < $${190.03}$$
agent_rpm_amd64_fips $${+0.01}$$ $${694.26}$$ < $${751.35}$$ $${+0.03}$$ $${177.43}$$ < $${189.81}$$
agent_rpm_arm64 $${+0}$$ $${685.98}$$ < $${739.42}$$ $${+0.06}$$ $${161.05}$$ < $${171.23}$$
agent_rpm_arm64_fips $${+0}$$ $${684.33}$$ < $${737.91}$$ $${-0.01}$$ $${160.07}$$ < $${170.22}$$
agent_suse_amd64 $${+0}$$ $${696.03}$$ < $${752.98}$$ $${+0.06}$$ $${177.55}$$ < $${190.03}$$
agent_suse_amd64_fips $${+0.01}$$ $${694.26}$$ < $${751.35}$$ $${+0.03}$$ $${177.43}$$ < $${189.81}$$
agent_suse_arm64 $${+0}$$ $${685.98}$$ < $${739.42}$$ $${+0.06}$$ $${161.05}$$ < $${171.23}$$
agent_suse_arm64_fips $${+0}$$ $${684.33}$$ < $${737.91}$$ $${-0.01}$$ $${160.07}$$ < $${170.22}$$
docker_agent_amd64 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_arm64 $${+0}$$ $${793.23}$$ < $${858.97}$$ $${+0.01}$$ $${255.97}$$ < $${274.36}$$
docker_agent_jmx_amd64 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_jmx_arm64 $${+0}$$ $${793.23}$$ < $${858.97}$$ $${+0.01}$$ $${255.97}$$ < $${274.36}$$
docker_agent_windows1809 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows1809_core $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows1809_core_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows1809_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows2022 $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows2022_core $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows2022_core_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_agent_windows2022_jmx $${+0}$$ $${779.83}$$ < $${849.39}$$ $${-0}$$ $${268.58}$$ < $${288.34}$$
docker_cluster_agent_amd64 $${+0.01}$$ $${259.19}$$ < $${259.73}$$ $${+0.01}$$ $${102.89}$$ < $${103.68}$$
docker_cluster_agent_arm64 $${+0}$$ $${273.58}$$ < $${274.24}$$ $${-0}$$ $${97.59}$$ < $${98.45}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${+0}$$ $${13.96}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.03}$$ < $${8.97}$$
dogstatsd_deb_arm64 $${+0}$$ $${29.16}$$ < $${30.08}$$ $${-0}$$ $${6.98}$$ < $${7.92}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.98}$$
iot_agent_deb_amd64 $${+0.01}$$ $${50.49}$$ < $${60.17}$$ $${-0}$$ $${12.85}$$ < $${15.82}$$
iot_agent_deb_arm64 $${+0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.15}$$ < $${13.86}$$
iot_agent_deb_armhf $${+0.01}$$ $${47.52}$$ < $${56.41}$$ $${+0.01}$$ $${11.21}$$ < $${13.86}$$
iot_agent_rpm_amd64 $${+0.01}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$
iot_agent_rpm_arm64 $${+0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.16}$$ < $${13.76}$$
iot_agent_suse_amd64 $${+0.01}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$

Copy link
Member

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Agent Runtimes

@remeh remeh force-pushed the remeh/rc-bl-histograms branch from 2acee9f to e127d1d Compare June 6, 2025 09:00
@remeh remeh force-pushed the remeh/rc-bl-histograms branch from e127d1d to 36f0629 Compare June 6, 2025 09:25
@remeh remeh force-pushed the remeh/rc-bl-histograms branch from cffb4e8 to 7558cd5 Compare June 6, 2025 10:14
@remeh remeh force-pushed the remeh/rc-bl-histograms branch from 7558cd5 to 159f026 Compare June 6, 2025 10:19
Copy link
Contributor

@vickenty vickenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some cosmetic comments, but otherwise LGTM.

func (s *server) createHistogramsBlocklist(metricNames []string) []string {
aggrs := s.config.GetStringSlice("histogram_aggregates")

percentiles := metrics.ParsePercentiles(s.config.GetStringSlice("histogram_percentiles"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move this function to the metrics package? So that all handling of percentiles is concentrated in one, rather than multiple packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's use-case is IMO closer to statsd than the percentiles/histograms themselves, don't you think?

@@ -124,7 +125,7 @@ func (s *TimeSampler) newSketchSeries(ck ckey.ContextKey, points []metrics.Sketc
return ss
}

func (s *TimeSampler) flushSeries(cutoffTime int64, series metrics.SerieSink) {
func (s *TimeSampler) flushSeries(cutoffTime int64, series metrics.SerieSink, blocklist *utilstrings.Blocklist) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than plumbing it through the entire flush call chain, would it make sense to store the blocklist directly in the time sampler, rather than the worker? That way we will need to refer to it only in two places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TimeSampler isn't waiting on a select or anything, each one are actually managed by the TimeSamplerWorker. I'm not sure that it would decrease the size of the chain since it would be on the worker to pass the list to the sampler: AFAIU (only checked quickly) the worker would still have the plumbing to pass the list to the sampler, it would just be stored somewhere else. Please let me know if you think I should look more into this, I can address it in a separate PR.

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, I left a few comments inline but none of them are blockers (feel free to either address them or discard them with an explanation)

func (s *server) createHistogramsBlocklist(metricNames []string) []string {
aggrs := s.config.GetStringSlice("histogram_aggregates")

percentiles := metrics.ParsePercentiles(s.config.GetStringSlice("histogram_percentiles"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of GetStringSlice("histogram_percentiles"), pkg/metrics/histogram uses structure.UnmarshalKey(config, "histogram_percentiles", &c). I'm not sure why but I think it's worth digging into it and making both config accesses consistent

@remeh
Copy link
Contributor Author

remeh commented Jun 10, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025

View all feedbacks in Devflow UI.

2025-06-10 07:36:48 UTC ℹ️ Start processing command /merge


2025-06-10 07:36:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).


2025-06-10 08:23:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ac84213 into main Jun 10, 2025
238 checks passed
@dd-mergequeue dd-mergequeue bot deleted the remeh/rc-bl-histograms branch June 10, 2025 08:23
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 10, 2025
@remeh remeh added the backport/7.67.x Automatically create a backport PR to 7.67.x label Jun 10, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request Jun 10, 2025
…sampler and the serializer (#37692)

(cherry picked from commit ac84213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.67.x Automatically create a backport PR to 7.67.x changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants