[Backport 7.67.x] [AMCC-11] dogstatsd: additional metric control mechanism between the sampler and the serializer #37828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![agent-platform-auto-pr[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
agent-platform-auto-pr
bot
added
qa/done
agent-platform-auto-pr
bot
added
the
long review
agent-platform-auto-pr
bot
added
changelog/no-changelog
qa/done
Go Package Import DifferencesBaseline: f4dd783
|
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
chouquette
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the #36761 change does not work properly for histograms (fails silently).
Backport ac84213 from #37692.
What does this PR do?
Adds an additional processing step when the time samplers is flushing data to the serializer for serialization.
This extra step is necessary since the aggregation from the time sampler might possibly generate new metrics, that would not have been correctly visible to the metric control implementation which is running in the listening part of DogStatsD.
This implementation creates a sublist in order to avoid having to do a complete second pass with the configured list. This sublist contain only the metrics names generated from histograms, a heuristic try to do this using a static list of histogram aggregates and percentile suffixes.
Describe how you validated your changes
Manual tested E2E on an org with the feature enabled, also, will be extensively dogfooded.