Add new track pieces to the Twister, Hyper Twister and Vertical Drop Roller Coasters #23051

mixiate · 2024-10-25T09:47:58Z

This adds new track pieces to the twister, hyper twister and vertical drop rollercoasters.

Large unbanked and banked sloped curves (Twister, Hyper, Vertical Drop)
Large corkscrews (Twister)
Medium half loops (Twister, Vertical Drop)
Small and large zero g rolls (Cheats)

All pieces have been tested with the applicable trains. The zero g rolls are currently cheats only as they don't seem to currently be optionally available only for trains that have the sprites. The trains don't have sprites for all the diagonal banking pieces either but these are already available for the giga coaster so I just made them available to these too. Maybe both of these things could be sorted out eventually.

SpartanFrederic104 · 2024-10-25T20:54:54Z

Did some testing with these new track pieces and they just look fantastic and smooth as usual.

I haven't found any major issues so far (well, excluding the vanilla trains glitching on some diagonal banked slope pieces and the lack of sprites for zero-G rolls). Can't wait to play with these new track pieces in a future release build!
(and yes these screenshots were taken before the force push was done)

mixiate · 2024-10-25T22:10:21Z

Thanks for testing them again, I really appreciate it. I just fixed a few pieces that didn't connect quite right, and a couple of supports that didn't reach, and rebased it. Hopefully this is all okay now.

fidwell · 2024-10-25T22:47:15Z

These look great. The corkscrews are even better looking than the originals. Nice work!

karst · 2024-10-25T22:52:49Z

Thanks for taking in my feedback regarding the polygon spines :)
Looks lovely!

karst · 2024-10-25T23:02:37Z

There's a few more things required before this can be merged:

Network version needs to be increased
There needs to be conversion code for making the new track pieces invisible on rides that already have them before this was added to the game. As an example check this: https://github.com/OpenRCT2/OpenRCT2/pull/17997/files#diff-5589e6ccdd14fc6e0ff9416f0dbd6b7bff23033380e8649da2336b84f0382e20R921-R937
To make this happen you also need to bump the park file version.

SpartanFrederic104 · 2024-11-04T18:20:50Z

Guessing this will need a rebase and the changelog entry moved to the v0.4.17 section?

mixiate · 2024-11-05T21:32:20Z

Yep, i'll sort this out as soon as I can.

Gymnasiast · 2024-11-08T22:14:06Z

src/openrct2/ride/rtd/coaster/VerticalDropCoaster.h

-        .enabledTrackGroups = {TrackGroup::flat, TrackGroup::straight, TrackGroup::stationEnd, TrackGroup::liftHill, TrackGroup::liftHillSteep, TrackGroup::flatRollBanking, TrackGroup::verticalLoop, TrackGroup::slope, TrackGroup::slopeSteepUp, TrackGroup::slopeSteepDown, TrackGroup::flatToSteepSlope, TrackGroup::slopeCurve, TrackGroup::slopeCurveSteep, TrackGroup::sBend, TrackGroup::curveSmall, TrackGroup::curve, TrackGroup::curveLarge, TrackGroup::helixDownBankedHalf, TrackGroup::helixUpBankedHalf, TrackGroup::brakes, TrackGroup::onridePhoto, TrackGroup::slopeVertical, TrackGroup::slopeCurveBanked, TrackGroup::blockBrakes, TrackGroup::slopeRollBanking, TrackGroup::curveVertical, TrackGroup::halfLoopLarge, TrackGroup::brakeForDrop, TrackGroup::diagBrakes, TrackGroup::diagBlockBrakes},
-        .extraTrackGroups = {TrackGroup::halfLoop, TrackGroup::corkscrew, TrackGroup::barrelRoll, TrackGroup::poweredLift, TrackGroup::halfLoopLarge, TrackGroup::quarterLoop, TrackGroup::booster, TrackGroup::twist},
+        .enabledTrackGroups = {TrackGroup::flat, TrackGroup::straight, TrackGroup::stationEnd, TrackGroup::liftHill, TrackGroup::liftHillSteep, TrackGroup::flatRollBanking, TrackGroup::verticalLoop, TrackGroup::slope, TrackGroup::slopeSteepUp, TrackGroup::slopeSteepDown, TrackGroup::flatToSteepSlope, TrackGroup::slopeCurve, TrackGroup::slopeCurveSteep, TrackGroup::sBend, TrackGroup::curveSmall, TrackGroup::curve, TrackGroup::curveLarge, TrackGroup::helixDownBankedHalf, TrackGroup::helixUpBankedHalf, TrackGroup::brakes, TrackGroup::onridePhoto, TrackGroup::slopeVertical, TrackGroup::slopeCurveBanked, TrackGroup::blockBrakes, TrackGroup::slopeRollBanking, TrackGroup::curveVertical, TrackGroup::halfLoopLarge, TrackGroup::brakeForDrop, TrackGroup::diagBrakes, TrackGroup::diagBlockBrakes, TrackGroup::slopeCurveLarge, TrackGroup::halfLoopMedium},
+        .extraTrackGroups = {TrackGroup::halfLoop, TrackGroup::corkscrew, TrackGroup::barrelRoll, TrackGroup::poweredLift, TrackGroup::halfLoopLarge, TrackGroup::quarterLoop, TrackGroup::booster, TrackGroup::twist, TrackGroup::zeroGRoll, TrackGroup::zeroGRollLarge, TrackGroup::corkscrewLarge},


Is there a particular reason to lock the Zero G Rolls behind a cheat?

imo there isn't, if a vehicle can't draw the pieces they'll be disabled anyhow, and the vertical drop coaster is known to have this element, especially immelmen.

Originally it was because none of the new inversions had entries for the sprites required, but that has now been fixed. I added the zero g rolls to the twister but forgot about updating these for the vertical drop coaster. Should the large corkscrew also be available?

Yeah definitely

yes and i made a lot of BM Cars now but i think we need an permission to make them official?

@mixiate Ok, could you apply that and rebase?

Done. I've checked that the park and network version are okay also.

karst · 2024-11-10T21:32:54Z

As far as I can see the code looks all good. I'll have a dev look at it tho.
I'll give this a playtest.

karst

Wonderful :) After some playing with it, all items seem to be working correctly. Conversion also works

karst · 2024-11-11T20:09:17Z

src/openrct2/park/Legacy.cpp

+            case TrackElemType::LeftLargeHalfLoopUp:
+            case TrackElemType::RightLargeHalfLoopUp:
+            case TrackElemType::LeftLargeHalfLoopDown:
+            case TrackElemType::RightLargeHalfLoopDown:


These four lines need to be removed. Sending a patch right away.

- Feature: [#23166] Add Galician translation. - Feature: [#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1. - Improved: [#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters. - Improved: [#23123] Improve sorting of roller coasters in build new ride menu. - Improved: [#23211] Add boosters to classic wooden roller coaster (cheats only). - Improved: [#23229] Add debug option for making the sprite sorting algorithm stable. - Improved: [#23233] Add diagonal booster to LSM Launched Coaster. - Improved: [#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire. - Fix: [#20070, #22972] Missing and mismatched flat and sloped footpaths on several scenarios. - Fix: [#22726] ‘Force park rating’ cheat is not saved with the park. - Fix: [#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned. - Fix: [#23066] Stand-Up Roller Coaster has many supports that don't join up to the track. - Fix: [#23206] Multiplayer desyncs when FPS is uncapped. - Fix: [#23238] Updating a guest’s favourite ride works differently from vanilla RCT2. - Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains. - Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.

Release v0.4.17 - Feature: [OpenRCT2#23166] Add Galician translation. - Feature: [OpenRCT2#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1. - Improved: [OpenRCT2#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters. - Improved: [OpenRCT2#23123] Improve sorting of roller coasters in build new ride menu. - Improved: [OpenRCT2#23211] Add boosters to classic wooden roller coaster (cheats only). - Improved: [OpenRCT2#23229] Add debug option for making the sprite sorting algorithm stable. - Improved: [OpenRCT2#23233] Add diagonal booster to LSM Launched Coaster. - Improved: [OpenRCT2#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire. - Fix: [OpenRCT2#20070, OpenRCT2#22972] Missing and mismatched flat and sloped footpaths on several scenarios. - Fix: [OpenRCT2#22726] ‘Force park rating’ cheat is not saved with the park. - Fix: [OpenRCT2#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned. - Fix: [OpenRCT2#23066] Stand-Up Roller Coaster has many supports that don't join up to the track. - Fix: [OpenRCT2#23206] Multiplayer desyncs when FPS is uncapped. - Fix: [OpenRCT2#23238] Updating a guest’s favourite ride works differently from vanilla RCT2. - Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains. - Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.

mixiate force-pushed the extended-twister-roller-coaster branch from 4a22540 to b64bd78 Compare October 25, 2024 20:38

karst added testing required PR needs to be tested before it is merged. feature Add something new to the game. network version Network version needs updating - double check before merging! park file version Requires updating the park file version number labels Oct 25, 2024

mixiate force-pushed the extended-twister-roller-coaster branch 2 times, most recently from 188a5b5 to 4ce4c76 Compare November 2, 2024 21:55

mixiate force-pushed the extended-twister-roller-coaster branch from 4ce4c76 to eb84266 Compare November 6, 2024 02:59

Gymnasiast added this to the v0.4.17 milestone Nov 8, 2024

Gymnasiast mentioned this pull request Nov 8, 2024

B&m track addings #21216

Closed

Gymnasiast reviewed Nov 8, 2024

View reviewed changes

mixiate added 12 commits November 10, 2024 21:12

Add large corkscrews to the Twister Roller Coaster

c412cc2

Add medium half loops to the Twister and Vertical Drop Roller Coaster

0a94311

Add large sloped turns to Twister, Hyper Twister and Vertical Drop RC

95bc00d

Add large bank slope turns to Twister, Hyper Twister and Vertical RC

16d5fd7

Add zero g rolls to the Twister Roller Coaster

2c3b3ee

Add large zero g rolls to the Twister Roller Coaster

e2ccc15

Make pre-existing new Twister RC track pieces invisible

1dcb05f

Add new Twister Roller Coaster track pieces to changelog

0e9a64d

Make large sloped turns available to the Flying Roller Coaster

c0810ed

Make Twister RC zero g rolls available if trains have sprites

b95e1bb

Add large corkscrews to Vertical Drop RC extra track piece list

a56d2ee

Make corkscrews and zero g rolls available to Vertical Drop RC

2e591a7

mixiate force-pushed the extended-twister-roller-coaster branch from eb84266 to 2e591a7 Compare November 10, 2024 21:18

karst approved these changes Nov 10, 2024

View reviewed changes

Gymnasiast approved these changes Nov 11, 2024

View reviewed changes

Gymnasiast merged commit fd90afe into OpenRCT2:develop Nov 11, 2024
23 checks passed

karst reviewed Nov 11, 2024

View reviewed changes

karst mentioned this pull request Nov 11, 2024

Hotfix: Disappearing large half loops on BM track #23188

Merged

Add new track pieces to the Twister, Hyper Twister and Vertical Drop Roller Coasters #23051

Add new track pieces to the Twister, Hyper Twister and Vertical Drop Roller Coasters #23051

Uh oh!

Conversation

mixiate commented Oct 25, 2024

Uh oh!

SpartanFrederic104 commented Oct 25, 2024

Uh oh!

mixiate commented Oct 25, 2024

Uh oh!

fidwell commented Oct 25, 2024

Uh oh!

karst commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karst commented Oct 25, 2024

Uh oh!

SpartanFrederic104 commented Nov 4, 2024

Uh oh!

mixiate commented Nov 5, 2024

Uh oh!

Gymnasiast Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

karst Nov 8, 2024

Choose a reason for hiding this comment

Uh oh!

mixiate Nov 9, 2024

Choose a reason for hiding this comment

Uh oh!

karst Nov 9, 2024

Choose a reason for hiding this comment

Uh oh!

Realsteel89 Nov 9, 2024

Choose a reason for hiding this comment

Uh oh!

Gymnasiast Nov 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mixiate Nov 10, 2024

Choose a reason for hiding this comment

Uh oh!

karst commented Nov 10, 2024

Uh oh!

karst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karst Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karst commented Oct 25, 2024 •

edited

Loading

Gymnasiast Nov 10, 2024 •

edited

Loading