Skip to content

Improve new ride menu sorting #23123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2024
Merged

Improve new ride menu sorting #23123

merged 3 commits into from
Nov 8, 2024

Conversation

ZeeMaji
Copy link
Contributor

@ZeeMaji ZeeMaji commented Nov 3, 2024

Improves the sorting of the new ride menu by making the following changes:

  1. Move the classic wooden coaster to be after the modern/RCT2 wooden coaster to make it consistent with the other classic ride types which are after their RCT2 counterparts in the menu.
  2. Move the LSM launched coaster to be between the hyper-twister & giga coaster, as it is essentially the non-hyper looping version of the giga coaster.
  3. Move the Lay-Down coaster, Flying coaster, & Multi-Dim coaster to be between the inverted impulse coaster & mini suspended coaster as this seems like an oversight that wasn't caught in RCT2's development as initially in RCT1AA solely the lay-down coaster resided here but it wasn't moved to it's own section of the build menu when it got two new similar rides added next to it, their original positions put a gap in the misc group that resides after the impulse coaster to the end of the coasters list. This fixes that by moving them to be after the inverted coasters but before the misc coasters.

Screenshot at 2024-11-03 17-39-26
Screenshot at 2024-11-03 17-39-38
Screenshot at 2024-11-03 17-39-47

Gymnasiast
Gymnasiast reviewed Nov 7, 2024
View reviewed changes
src/openrct2-ui/windows/NewRide.cpp Outdated
RIDE_TYPE_WOODEN_ROLLER_COASTER,
RIDE_TYPE_CLASSIC_WOODEN_ROLLER_COASTER,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should sort the "classic" types before their RCT2 after all. After all, it sort-of represents an older coaster type in much the same way that the side-friction, virginia reel and reverser do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure, because on the other hand you have the classic mini coaster which is more advanced than the junior so it seems weird to put it before the less capable junior coaster. The classic stand-up is also kind of like this thanks to it having powered launches & a higher max build height so it would be weird to put it before the RCT2 stand-up imo. Although it does lack helix pieces so there is that against it at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, let’s just put the Classic Wooden before the regular one and leave the others where they are.

@Gymnasiast Gymnasiast enabled auto-merge (squash) November 8, 2024 21:05
@Gymnasiast Gymnasiast added this to the v0.4.17 milestone Nov 8, 2024
@Gymnasiast Gymnasiast merged commit d76aff3 into OpenRCT2:develop Nov 8, 2024
22 checks passed
janisozaur added a commit that referenced this pull request Dec 8, 2024
@janisozaur
Release v0.4.17
74aff4e 
- Feature: [#23166] Add Galician translation.
- Feature: [#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1.
- Improved: [#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters.
- Improved: [#23123] Improve sorting of roller coasters in build new ride menu.
- Improved: [#23211] Add boosters to classic wooden roller coaster (cheats only).
- Improved: [#23229] Add debug option for making the sprite sorting algorithm stable.
- Improved: [#23233] Add diagonal booster to LSM Launched Coaster.
- Improved: [#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire.
- Fix: [#20070, #22972] Missing and mismatched flat and sloped footpaths on several scenarios.
- Fix: [#22726] ‘Force park rating’ cheat is not saved with the park.
- Fix: [#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned.
- Fix: [#23066] Stand-Up Roller Coaster has many supports that don't join up to the track.
- Fix: [#23206] Multiplayer desyncs when FPS is uncapped.
- Fix: [#23238] Updating a guest’s favourite ride works differently from vanilla RCT2.
- Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains.
- Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.
janisozaur added a commit that referenced this pull request Dec 8, 2024
@janisozaur
Release v0.4.17
0faf009 
- Feature: [#23166] Add Galician translation.
- Feature: [#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1.
- Improved: [#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters.
- Improved: [#23123] Improve sorting of roller coasters in build new ride menu.
- Improved: [#23211] Add boosters to classic wooden roller coaster (cheats only).
- Improved: [#23229] Add debug option for making the sprite sorting algorithm stable.
- Improved: [#23233] Add diagonal booster to LSM Launched Coaster.
- Improved: [#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire.
- Fix: [#20070, #22972] Missing and mismatched flat and sloped footpaths on several scenarios.
- Fix: [#22726] ‘Force park rating’ cheat is not saved with the park.
- Fix: [#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned.
- Fix: [#23066] Stand-Up Roller Coaster has many supports that don't join up to the track.
- Fix: [#23206] Multiplayer desyncs when FPS is uncapped.
- Fix: [#23238] Updating a guest’s favourite ride works differently from vanilla RCT2.
- Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains.
- Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.
janisozaur added a commit that referenced this pull request Dec 8, 2024
@janisozaur
Release v0.4.17
c220cbc 
- Feature: [#23166] Add Galician translation.
- Feature: [#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1.
- Improved: [#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters.
- Improved: [#23123] Improve sorting of roller coasters in build new ride menu.
- Improved: [#23211] Add boosters to classic wooden roller coaster (cheats only).
- Improved: [#23229] Add debug option for making the sprite sorting algorithm stable.
- Improved: [#23233] Add diagonal booster to LSM Launched Coaster.
- Improved: [#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire.
- Fix: [#20070, #22972] Missing and mismatched flat and sloped footpaths on several scenarios.
- Fix: [#22726] ‘Force park rating’ cheat is not saved with the park.
- Fix: [#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned.
- Fix: [#23066] Stand-Up Roller Coaster has many supports that don't join up to the track.
- Fix: [#23206] Multiplayer desyncs when FPS is uncapped.
- Fix: [#23238] Updating a guest’s favourite ride works differently from vanilla RCT2.
- Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains.
- Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.
janisozaur added a commit that referenced this pull request Dec 8, 2024
@janisozaur
Release v0.4.17
60dc190 
- Feature: [#23166] Add Galician translation.
- Feature: [#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1.
- Improved: [#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters.
- Improved: [#23123] Improve sorting of roller coasters in build new ride menu.
- Improved: [#23211] Add boosters to classic wooden roller coaster (cheats only).
- Improved: [#23229] Add debug option for making the sprite sorting algorithm stable.
- Improved: [#23233] Add diagonal booster to LSM Launched Coaster.
- Improved: [#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire.
- Fix: [#20070, #22972] Missing and mismatched flat and sloped footpaths on several scenarios.
- Fix: [#22726] ‘Force park rating’ cheat is not saved with the park.
- Fix: [#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned.
- Fix: [#23066] Stand-Up Roller Coaster has many supports that don't join up to the track.
- Fix: [#23206] Multiplayer desyncs when FPS is uncapped.
- Fix: [#23238] Updating a guest’s favourite ride works differently from vanilla RCT2.
- Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains.
- Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.
CorySanin added a commit to CorySanin/OpenRCT2 that referenced this pull request Feb 3, 2025
@CorySanin
Merge tag 'v0.4.17' into saveprep
514c58c 
Release v0.4.17

- Feature: [OpenRCT2#23166] Add Galician translation.
- Feature: [OpenRCT2#23227] Add Classic Wooden Twister roller coaster, for better compatibility with RCT1.
- Improved: [OpenRCT2#23051] Add large sloped turns and new inversions to the Twister, Vertical Drop, Hyper and Flying Roller Coasters.
- Improved: [OpenRCT2#23123] Improve sorting of roller coasters in build new ride menu.
- Improved: [OpenRCT2#23211] Add boosters to classic wooden roller coaster (cheats only).
- Improved: [OpenRCT2#23229] Add debug option for making the sprite sorting algorithm stable.
- Improved: [OpenRCT2#23233] Add diagonal booster to LSM Launched Coaster.
- Improved: [OpenRCT2#23277] Add small, medium and large turns, diagonal track and S-bends to the Boat Hire.
- Fix: [OpenRCT2#20070, OpenRCT2#22972] Missing and mismatched flat and sloped footpaths on several scenarios.
- Fix: [OpenRCT2#22726] ‘Force park rating’ cheat is not saved with the park.
- Fix: [OpenRCT2#23064] Stand-Up Roller Coaster unbanked to banked track pieces are misaligned.
- Fix: [OpenRCT2#23066] Stand-Up Roller Coaster has many supports that don't join up to the track.
- Fix: [OpenRCT2#23206] Multiplayer desyncs when FPS is uncapped.
- Fix: [OpenRCT2#23238] Updating a guest’s favourite ride works differently from vanilla RCT2.
- Fix: [objects#355] Fix colour preset settings of the Stand-Up Roller Coaster trains.
- Fix: [objects#355] Fix colour preset settings of many vehicles from Wacky Worlds and Time Twister.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.17
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeeMaji @Gymnasiast