NSIS: disable languages without translations #24615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSIS has the LangString system which allows us to customise the strings that are specific to our project. All fine and dandy, but it has the annoying peculiarity that when referring to a LangString that doesn’t have a translation for the current language, it will not fall back to English, but instead just appear empty.
This leads to situations like this:
Rather than adding a load of copies of English, I have instead decided to just disable all languages that don’t have translations for these strings yet, and re-activate them once a translator adds them. Not ideal, but NSIS leaves us no other choice.
@leicestersquare Could you test a build of this PR and see if it now displays in English?