Skip to content

NSIS: disable languages without translations #24615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Gymnasiast
Copy link
Member

NSIS has the LangString system which allows us to customise the strings that are specific to our project. All fine and dandy, but it has the annoying peculiarity that when referring to a LangString that doesn’t have a translation for the current language, it will not fall back to English, but instead just appear empty.

This leads to situations like this:

afbeelding
afbeelding

Rather than adding a load of copies of English, I have instead decided to just disable all languages that don’t have translations for these strings yet, and re-activate them once a translator adds them. Not ideal, but NSIS leaves us no other choice.

@leicestersquare Could you test a build of this PR and see if it now displays in English?

@Gymnasiast Gymnasiast added this to the v0.4.24 milestone Jun 13, 2025
@Gymnasiast Gymnasiast added changelog This issue/PR deserves a changelog entry. testing required PR needs to be tested before it is merged. labels Jun 13, 2025
@leicestersquare
Copy link
Contributor

image
image
yes this works

@Gymnasiast Gymnasiast force-pushed the fix/missing-strings-in-installer branch from 3d9abea to 7e31c9a Compare June 16, 2025 21:07
@Gymnasiast Gymnasiast enabled auto-merge (squash) June 16, 2025 21:08
@Gymnasiast Gymnasiast merged commit 1222670 into OpenRCT2:develop Jun 16, 2025
22 checks passed
@Gymnasiast Gymnasiast deleted the fix/missing-strings-in-installer branch June 16, 2025 21:30
Gymnasiast added a commit that referenced this pull request Jul 5, 2025
- Feature: [#24411] Vanilla scenarios now also have previews in the scenario selection window.
- Feature: [#24616] Add ability to scroll map with gamepad sticks.
- Feature: [#24662] Add optional screenshot argument for Z coord.
- Improved: [#22684] The limit of 2000 animated tile elements has been removed.
- Improved: [#23228] Landscape edge doors now animate opening and closing and play a sound.
- Improved: [#24026] Notification settings have been made into a tab of the Recent Messages window.
- Improved: [#24569, #24710] Add ten additional translations to the Windows installer.
- Change: [#24559] Scenario options are now disabled rather than hidden when disabling money makes them non-applicable.
- Change: [objects#383] Disable all base colours on non-remappable WWTT vehicles, change black to light_blue.
- Change: [objects#384] Remove erroneously enabled WWTT third remaps.
- Removed: [#24628] “Pause game when Steam overlay is open” feature (already broken for a long time).
- Removed: [#24640] Grouping by difficulty (instead of per campaign) in the scenario selector.
- Fix: [#15846] Rightclicking on track piece when there is construction below does not work.
- Fix: [#16176, #23113] Animated tile elements do not always redraw when there is over 2000.
- Fix: [#17365] The slope of new land surfaces is only correct on one side when shifting and resizing the map.
- Fix: [#18080] Obsolete official .DAT files can be loaded accidentally.
- Fix: [#21703] Scenery wall doors get stuck open if the game is saved and loaded whilst they are open.
- Fix: [#24456] Zoomed out vehicles on the ride window tab can sometimes draw incorrectly.
- Fix: [#24458] Vehicles in the ride window vehicle tab are offset differently than vanilla RCT2, and the sprites are cut off at the bottom.
- Fix: [#24576] It is possible to edit open rides in certain circumstances.
- Fix: [#24589] Music tab doesn’t fully render in multiplayer.
- Fix: [#24615] Blank strings in Windows installer.
- Fix: [#24617] ‘Divide by zero’ error when updating boat hire acceleration.
- Fix: [#24626] Viewports that only follow sprites (e.g. in the Ride and Guest windows) can be made to unfollow them.
- Fix: [#24661] `convert` console command always crashes with a segmentation fault.
- Fix: [#24666] `convert` console command rejects files with an SV7 extension.
- Fix: [objects#388] ‘Italian Police Ride’ has a non-functional first remap colour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This issue/PR deserves a changelog entry. testing required PR needs to be tested before it is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants