[Android] fix: Navigation bar not updating after the current tab is removed. #30566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a navigation bar bug where the menu/navigation bar fails to update properly after the current tab is removed in Android Shell applications. The issue occurs when DisplayedPage becomes null but the menu setup state isn't reset, preventing proper reconfiguration when a new page takes its place.
Key Changes
- Adds state reset logic in
SetupMenu()method to clear the_menuSetupflag whenDisplayedPageis null - Ensures menu reconfiguration happens correctly after tab removal and replacement
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs:457
- This bug fix addresses navigation bar behavior when tabs are removed, but there's no corresponding test case visible for this scenario. According to the coding guidelines, all code changes should have relevant test cases in TestCases.HostApp and TestCases.Shared.Tests to verify the navigation bar updates correctly after tab removal.
if (DisplayedPage is null)
|
Hey there @@Rover656! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Rover656
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Makes sure that if SetupMenu opts to short-circuit when the
DisplayedPageis null, we clear_menuSetupso that the menu is correctly reconfigured after a new screen takes its place.Issues Fixed
Fixes #30565