Skip to content

Single-canvas inline, drop XRPresentationContext #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 13, 2019
Merged

Single-canvas inline, drop XRPresentationContext #656

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b7a1a8f
Single-canvas inline, drop XRPresentationContext
toji May 17, 2019
771b48a
Updated the explainer
toji May 17, 2019
2dbf9f1
Addressing some feedback
toji May 22, 2019
bed660f
Move direct output flag to render state
toji May 23, 2019
9b65d29
Comment about the WebGLRenderingContext's attributes taking precedenc…
toji May 23, 2019
458034b
Changed option to compositionDisabled
toji May 28, 2019
41c03e6
Fixed up explainer
toji May 29, 2019
006f5a1
Fixed a broken link to an outdated product
toji May 31, 2019
dfbc4bb
Change composition disabled to be implicit based on session type
toji Jun 12, 2019
a0a5310
Fixing a few loose ends
toji Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Single-canvas inline, drop XRPresentationContext 
Fixes #636

This change adds a path for using a single WebGL canvas to drive inline
sessions, rather than needing both a WebGL context and an
XRPresentationContext before the inline session can function. The way to
do this is to create an `XRWebGLLayer` with the `useDefaultFramebuffer`
option set to `true` and set it as the session's `baseLayer`.

In addition to the above, this change removes the XRPresentationContext
entirely, and along with it the ability to do desktop mirroring (and
more advanced inline scenarios.) This is to simplify the core API, and
equivalent functionality will be reconsidered in the future because the
functionality that they represent is valuable.
  • Loading branch information
@toji
toji committed Jun 13, 2019
commit b7a1a8fd6cee0329f80c2c317bf0fcc497c38ae5
Loading