Skip to content

Single-canvas inline, drop XRPresentationContext #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 13, 2019
Merged

Single-canvas inline, drop XRPresentationContext #656

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b7a1a8f
Single-canvas inline, drop XRPresentationContext
toji May 17, 2019
771b48a
Updated the explainer
toji May 17, 2019
2dbf9f1
Addressing some feedback
toji May 22, 2019
bed660f
Move direct output flag to render state
toji May 23, 2019
9b65d29
Comment about the WebGLRenderingContext's attributes taking precedenc…
toji May 23, 2019
458034b
Changed option to compositionDisabled
toji May 28, 2019
41c03e6
Fixed up explainer
toji May 29, 2019
006f5a1
Fixed a broken link to an outdated product
toji May 31, 2019
dfbc4bb
Change composition disabled to be implicit based on session type
toji Jun 12, 2019
a0a5310
Fixing a few loose ends
toji Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change composition disabled to be implicit based on session type
  • Loading branch information
@toji
toji committed Jun 13, 2019
commit dfbc4bb685a1d500e184ce713364f5ce16aac8ad
11 changes: 8 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,6 @@ typedef (WebGLRenderingContext or
WebGL2RenderingContext) XRWebGLRenderingContext;

dictionary XRWebGLLayerInit {
boolean compositionDisabled = false;
boolean antialias = true;
boolean depth = true;
boolean stencil = false;
Expand Down Expand Up @@ -1595,7 +1594,13 @@ The <dfn constructor for="XRWebGLLayer">XRWebGLLayer(|session|, |context|, |laye
<dt> Otherwise
<dd> Initialize |layer|'s {{XRWebGLLayer/ignoreDepthValues}} to <code>true</code>
</dl>
1. Initialize |layer|'s [=XRWebGLLayer/composition disabled=] boolean to |layerInit|'s {{XRWebGLLayerInit/compositionDisabled}}.
1. Initialize |layer|'s [=XRWebGLLayer/composition disabled=] boolean as follows:
<dl class="switch">
<dt> If |session| is an [=immersive session=]
<dd> Initialize |layer|'s [=XRWebGLLayer/composition disabled=] boolean to <code>false</code>
<dt> Otherwise
<dd> Initialize |layer|'s [=XRWebGLLayer/composition disabled=] to <code>true</code>
</dl>
1. <dl class="switch">
<dt> If |layer|'s [=XRWebGLLayer/composition disabled=] boolean is <code>false</code>:
<dd>
Expand All @@ -1614,7 +1619,7 @@ The <dfn constructor for="XRWebGLLayer">XRWebGLLayer(|session|, |context|, |laye

</div>

Note: When a {{XRWebGLLayerInit}}'s {{XRWebGLLayerInit/compositionDisabled}} is set to <code>true</code> all other values on the {{XRWebGLLayerInit}} object are ignored, since the {{WebGLRenderingContext}}'s default framebuffer was already allocated using the context's [=actual context parameters=] and cannot be overridden.
Note: If a {{XRWebGLLayer}}'s {{XRWebGLLayerInit/composition disabled}} boolean is set to <code>true</code> all values on the {{XRWebGLLayerInit}} object are ignored, since the {{WebGLRenderingContext}}'s default framebuffer was already allocated using the context's [=actual context parameters=] and cannot be overridden.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should both of these have been changed to XRWebGLLayer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Yes. One sec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


The <dfn attribute for="XRWebGLLayer">context</dfn> attribute is the {{WebGLRenderingContext}} the {{XRWebGLLayer}} was created with.

Expand Down