Handle detached arrays #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that there's now an explicit algorithm for obtaining XRRigidTransform.matrix it may also be worth fleshing it out by saying exactly how this matrix is to be obtained, the same way we do for XRRay already. |
NellWaliczek
approved these changes
Jun 5, 2019
|
filed #686 |
bialpio
added a commit
to bialpio/webxr
that referenced
this pull request
Jun 19, 2019
Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR immersive-web#684.
toji
pushed a commit
that referenced
this pull request
Jun 19, 2019
Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR #684.
Squareys
reviewed
Jul 1, 2019
| @@ -1106,10 +1111,21 @@ The <dfn attribute for="XRRigidTransform">position</dfn> attribute is a 3-dimens | |||
|
|
|||
| The <dfn attribute for="XRRigidTransform">orientation</dfn> attribute is a quaternion describing the rotational component of the transform. The {{XRRigidTransform/orientation}} MUST be normalized to have a length of <code>1.0</code>. | |||
|
|
|||
| The <dfn attribute for="XRRigidTransform">matrix</dfn> attribute returns the transform described by the {{XRRigidTransform/position}} and {{XRRigidTransform/orientation}} attributes as a [=matrix=]. This attribute SHOULD be lazily evaluated. | |||
| The <dfn attribute for="XRRigidTransform">matrix</dfn> attribute returns the transform described by the {{XRRigidTransform/position}} and {{XRRigidTransform/orientation}} attributes as a [=matrix=]. This attribute MUST be computed by [=XRRigidTransform/obtain the matrix|obtaining the matrix=] for the {{XRRigidTransform}}. | |||
There was a problem hiding this comment.
@Manishearth @toji Sorry for the post-merge comment here:
The "lazy evaluated" part originally introduced in #560 disappeared here. As it is viable to use a DualQuaternion as view transform directly, it would make sense to keep the matrix computation optional. It's just a nit-optimization for a currently less common use case, of course.
Or does "MUST be computed" imply it's computed on access?
There was a problem hiding this comment.
Alright, awesome, thanks for the clarification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Option 2 from #630 (comment)
fixes #630
r? @toji @NellWaliczek