Skip to content

Fix detached array in XRRay.matrix algorithm #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

bialpio
Copy link
Contributor

@bialpio bialpio commented Jun 19, 2019

Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR #684.

Fix algorithm for obtaining XRRay.matrix - copy-paste error introduced by PR immersive-web#684.
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@toji
Copy link
Member

toji commented Jun 19, 2019

Marked as non substantive for IPR from ash-nazg.

@toji
Copy link
Member

toji commented Jun 19, 2019

Thanks! Marked this change as non substantive because it's effectively a typo correction. That way you don't have to go through the IPR process prior to merging.

@toji toji merged commit a8e2a40 into immersive-web:master Jun 19, 2019
@bialpio
Copy link
Contributor Author

bialpio commented Jun 19, 2019

Thanks! I've linked my W3C account to the github account but only after issuing the PR & seeing some red there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants