-
Notifications
You must be signed in to change notification settings - Fork 22.8k
chore: Move Games sidebar into front matter #40322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URLs (66 pages)
Flaws (104)Note! 38 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if we land this, we should remove the macro from translated content because it's been renamed. See https://redirect.github.com/mdn/translated-content/pull/27971
Description
This PR:
files/sidebars/gamessidebar.yaml
tofiles/sidebars/games.yaml
sidebar: games
to the front matter{{GamesSidebar}}
macroMotivation
With the support for sidebars in front matter, the sidebar macro can be removed now
Related issues and pull requests