-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
installer: external assets #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: external assets #2916
Conversation
e041a13
to
8c4d65d
Compare
The log output on Github actions is so useless. It's scrambling the lines for some reason, even in the raw log.
|
What about the python license file? Do we need to include it? I feel like this is pynsist's job. |
It is pynsist's job. But it probably should be included, depends on what the licence says :) |
https://github.com/streamlink/streamlink/pull/2916/files#diff-6871e707e71cec9606ed3e5534cc4516 Ok, that should probably not be deleted, but instead fixed up. |
8c4d65d
to
9fde3ce
Compare
Restored Still not sure how to feel about the removal of the license files of the libs bundled by FFmpeg. The zeranoe build archive should include these, but it doesn't. Maybe include this? |
9fde3ce
to
5b2165c
Compare
I've submitted streamlink/streamlink-assets#2 earlier today which should resolve the ffmpeg license issue. This needs to be merged first before I can push my changes here. Btw, also did a bit of research regarding the Python license and from what it looks like, it's simply missing from the |
5b2165c
to
37e7eec
Compare
The ffmpeg build info is now included and the assets related log output a bit more verbose: That should be it regarding the external assets and their licenses. Btw, |
Have you made all the changes you want to make for this PR @bastimeyer? |
Unless you've spotted another issue, I think it's ready to be merged. |
Looks good to me, let's see if @back-to can spot anything :D |
Ehm, do we even include Streamlink's license in the installer? I don't think so...
|
37e7eec
to
5e64f29
Compare
- Move removed plugins list into a text file and read from it - Add log and err functions - Define build dependencies - Set repo root directory instead of assuming it - Clean up build directory before building the installer - Set dist dir to same STREAMLINK_DIST_DIR - Suppress warning/error messages from inkscape and imagemagick - Replace some strings in pynsist config with variables - Add Streamlink license file to pynsist config - Update python license text according to the currently used version - Remove unneeded pbs license text
from streamlink/streamlink-assets
5e64f29
to
ed6bbb3
Compare
Changes look good to me. 👍 |
…-assets installer: external assets
Resolves #2872
and upgrades FFMpeg to 4.2.2 (Zeranoe)
Changes