Skip to content

docs: remove RosadinTV Windows portable version #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2021
Merged

docs: remove RosadinTV Windows portable version #3535

merged 1 commit into from
Feb 7, 2021

Conversation

bastimeyer
Copy link
Member

as it is unmaintained and currently incompatible with Streamlink 2.0.0

Since the repo is currently hosted at streamlink/streamlink-portable, what should we do with it? Should this be archived?

@back-to
Copy link
Collaborator

back-to commented Feb 3, 2021

as it is unmaintained and currently incompatible with Streamlink 2.0.0

No, it still works.

Streamlink.exe -l debug twitch.tv/. 360p

[Streamlink for Windows v2.0.0 - Git aaf8db9]
[cli][debug] OS:         Windows 10
[cli][debug] Python:     3.6.3
[cli][debug] Streamlink: 2.0.0+aaf8db9
[cli][debug] Requests(2.18.4), Socks(1.6.7), Websocket(0.44.0)
[cli][info] Found matching plugin twitch for URL twitch.tv/.
[plugins.twitch][debug] Getting live HLS streams for .
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 360p (hls)
[stream.hls][debug] Reloading playlist
[stream.hls][debug] First Sequence: 1159; Last Sequence: 1165
[stream.hls][debug] Start offset: 0; Duration: None; Start Sequence: 1163; End Sequence: None
[stream.hls][debug] Adding segment 1163 to queue
[cli][debug] Pre-buffering 8192 bytes
[stream.hls][debug] Adding segment 1164 to queue
[stream.hls][debug] Adding segment 1165 to queue
[stream.hls][debug] Download of segment 1163 complete
[cli][info] Starting player: "C:\Program Files\VideoLAN\VLC\vlc.exe"
[cli.output][debug] Opening subprocess: "C:\Program Files\VideoLAN\VLC\vlc.exe" --input-title-format twitch.tv/. -
[stream.hls][debug] Download of segment 1164 complete
[stream.hls][debug] Download of segment 1165 complete
[cli][debug] Writing stream to output
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 1166 to queue
[stream.hls][debug] Adding segment 1167 to queue

Ref #3266

@bastimeyer
Copy link
Member Author

[Streamlink for Windows v2.0.0 - Git aaf8db9]
usage: Streamlink [OPTIONS] [STREAM]
streamlink: error: unrecognized arguments: --no-version-check
[End of Streamlink for Windows with ExitCode 2]

@back-to
Copy link
Collaborator

back-to commented Feb 3, 2021

streamlink: error: unrecognized arguments: --no-version-check

this might be an issue with your setup.

try a fresh windows 10 install, it will work.

@bastimeyer
Copy link
Member Author

https://github.com/streamlink/streamlink-portable/blob/e00e2467a70211a272701d0e3f902da1059771ab/Streamlink%20for%20Windows%20(Compiled)/Files/Resources/BAT_BUILD.txt#L79

@bastimeyer bastimeyer force-pushed the docs/install/remove-windows-portable-rosadintv branch from 2b3eda4 to e53a7d3 Compare February 3, 2021 20:43
@bastimeyer bastimeyer changed the title docs: remove RosadinTV Windows portable version docs: mark RosadinTV Windows portable as unmaintained Feb 3, 2021
@back-to
Copy link
Collaborator

back-to commented Feb 7, 2021

I tried to update all the dependencies of streamlink/streamlink-portable which is straight forward,
but there are some other bugs such as ffmpeg / rtmpdump missing since #2916
also some bugs when doing some rebuilts.

Doesn't seems to be worth fixing.

Well if you want to remove it from the docs,
Archived it first and add a Note that it is [Unmainted] in the Description
might also add this URL as Website https://streamlink.github.io/install.html#windows-portable-version

@bastimeyer
docs: remove RosadinTV Windows portable version
56b0e31 
as it is unmaintained and currently incompatible with Streamlink 2.0.0
@bastimeyer bastimeyer force-pushed the docs/install/remove-windows-portable-rosadintv branch from e53a7d3 to 56b0e31 Compare February 7, 2021 14:24
@bastimeyer bastimeyer changed the title docs: mark RosadinTV Windows portable as unmaintained docs: remove RosadinTV Windows portable version Feb 7, 2021
@bastimeyer
Copy link
Member Author

I've updated the repo description and link. Once this PR gets merged, I'll close all the remaining issues on that repo, add a commit with a note in the README.md header and archive the repo.

@back-to back-to merged commit 6646c72 into streamlink:master Feb 7, 2021
@bastimeyer bastimeyer deleted the docs/install/remove-windows-portable-rosadintv branch February 7, 2021 14:38
@bastimeyer bastimeyer mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastimeyer @back-to