build: add plugins JSON build script #5793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
plugins-json
branch
6 times, most recently
from
2e67ef0 to
09da0a1
Compare
bastimeyer
force-pushed
the
plugins-json
branch
from
09da0a1 to
d0f4b85
Compare
bastimeyer
force-pushed
the
plugins-json
branch
3 times, most recently
from
f84a645 to
f16d8d8
Compare
bastimeyer
force-pushed
the
plugins-json
branch
from
f16d8d8 to
0b941ab
Compare
|
Rebased to master... Going to open the lazy plugins loader PR now with these changes included. Once everything's validated and potential issues resolved, this PR here will get merged first, then the lazy plugins loader PR will be rebased and merged after that. |
bastimeyer
force-pushed
the
plugins-json
branch
from
0b941ab to
8d9a606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4741
Part 1/x
This adds the plugins JSON build script + setuptools hook, and a CI test job for it.
The build script parses each plugin file and reads the pluginmatcher and pluginargument data by walking the module's abstract syntax tree. The result is the JSON-serialized pluginmatcher and pluginargument data of each plugin without having to install Streamlink and import any plugin modules. There are many cases though where parsing could fail, depending on the plugin implementation, for example because object references are not supported. That's why the pluginmatcher and pluginargument data is now defined very strictly.
The next step (different PR) will be implementing the session and CLI logic for reading the JSON and loading only the matching plugin module based on that.