Skip to content

[AGENTRUN-310] Remove FIPS Proxy status to FIPS Agent status output #36988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

[AGENTRUN-310] Remove FIPS Proxy status to FIPS Agent status output #36988

merged 3 commits into from
May 22, 2025

Conversation

misteriaud
Copy link
Contributor

What does this PR do?

This PR removes the FIPS-proxy status from the FIPS Agent when fips.enable: true.

Motivation

We don't want to print that the Agent communications go through the FIPS Proxy when using the FIPS Agent.

  FIPS proxy
  ==========
    FIPS proxy is enabled. All communication to Datadog is routed to a local FIPS proxy:
      - Local address: localhost
      - Starting port: 9803

Describe how you validated your changes

I updated the agent status e2e test to cover this specific case.

@misteriaud misteriaud requested a review from a team as a code owner May 14, 2025 16:34
@misteriaud misteriaud requested a review from hush-hush May 14, 2025 16:34
@misteriaud misteriaud added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels May 14, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 14, 2025 •
edited
Loading

Uncompressed package size comparison

Comparison with ancestor 61f876ef64b98faf5968ed515b72d101d0d0a545

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB ✅ 773.33MB 773.33MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB ✅ 782.28MB 782.28MB 0.50MB
datadog-agent-x86_64-suse 0.00MB ✅ 782.28MB 782.28MB 0.50MB
datadog-agent-arm64-deb 0.00MB ✅ 759.28MB 759.28MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB ✅ 768.21MB 768.21MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.99MB 31.99MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 32.07MB 32.07MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.47MB 30.47MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 380.13MB 380.13MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 62.70MB 62.70MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 62.78MB 62.78MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 62.78MB 62.78MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 59.35MB 59.35MB 0.50MB

Decision

✅ Passed

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented May 14, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 962a35c7-a4eb-4265-a833-efc153b2e6ae

Baseline: 61f876e
Comparison: aba0d59
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ uds_dogstatsd_to_api_cpu % cpu utilization +1.99 [+1.07, +2.91] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.49 [+0.33, +0.65] 1 Logs
➖ quality_gate_logs % cpu utilization +0.46 [-2.17, +3.08] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization +0.41 [+0.27, +0.55] 1 Logs
➖ file_tree memory utilization +0.35 [+0.20, +0.50] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.10 [+0.05, +0.14] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.59, +0.70] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.56, +0.61] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.02 [-0.63, +0.68] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.02 [-0.22, +0.26] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.02 [-0.26, +0.29] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.00 [-0.64, +0.64] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.05 [-0.59, +0.48] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.70, +0.59] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.07 [-0.14, -0.00] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.09 [-0.71, +0.54] 1 Logs
➖ docker_containers_memory memory utilization -0.27 [-0.35, -0.18] 1 Logs
➖ ddot_metrics memory utilization -0.34 [-0.46, -0.23] 1 Logs
➖ otlp_ingest_logs memory utilization -0.48 [-0.61, -0.36] 1 Logs
➖ quality_gate_idle memory utilization -0.77 [-0.83, -0.71] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -1.58 [-1.70, -1.46] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization -1.92 [-5.56, +1.73] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@jeremy-hanna jeremy-hanna mentioned this pull request May 14, 2025
Closed
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 14, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 746.05 MiB 752.99 MiB 184.73 MiB 187.44 MiB
✅ static_quality_gate_agent_deb_amd64_fips 744.42 MiB 751.36 MiB 184.19 MiB 187.06 MiB
✅ static_quality_gate_agent_heroku_amd64 368.5 MiB 369.68 MiB 98.53 MiB 99.55 MiB
✅ static_quality_gate_agent_msi 977.19 MiB 978.01 MiB 148.36 MiB 149.12 MiB
✅ static_quality_gate_agent_rpm_amd64 746.04 MiB 752.98 MiB 186.43 MiB 190.03 MiB
✅ static_quality_gate_agent_rpm_amd64_fips 744.4 MiB 751.35 MiB 186.17 MiB 189.81 MiB
✅ static_quality_gate_agent_rpm_arm64 732.62 MiB 739.42 MiB 168.41 MiB 171.23 MiB
✅ static_quality_gate_agent_rpm_arm64_fips 731.11 MiB 737.91 MiB 167.56 MiB 170.22 MiB
✅ static_quality_gate_agent_suse_amd64 746.04 MiB 752.98 MiB 186.43 MiB 190.03 MiB
✅ static_quality_gate_agent_suse_amd64_fips 744.4 MiB 751.35 MiB 186.17 MiB 189.81 MiB
✅ static_quality_gate_agent_suse_arm64 732.62 MiB 739.42 MiB 168.41 MiB 171.23 MiB
✅ static_quality_gate_agent_suse_arm64_fips 731.11 MiB 737.91 MiB 167.56 MiB 170.22 MiB
✅ static_quality_gate_docker_agent_amd64 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_arm64 839.87 MiB 858.97 MiB 267.89 MiB 274.36 MiB
✅ static_quality_gate_docker_agent_jmx_amd64 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_jmx_arm64 839.87 MiB 858.97 MiB 267.89 MiB 274.36 MiB
✅ static_quality_gate_docker_agent_windows1809 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows1809_core 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows1809_core_jmx 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows1809_jmx 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows2022 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows2022_core 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows2022_core_jmx 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_agent_windows2022_jmx 829.82 MiB 849.39 MiB 281.77 MiB 288.34 MiB
✅ static_quality_gate_docker_cluster_agent_amd64 258.91 MiB 259.73 MiB 102.77 MiB 103.68 MiB
✅ static_quality_gate_docker_cluster_agent_arm64 273.41 MiB 274.24 MiB 97.52 MiB 98.45 MiB
✅ static_quality_gate_docker_cws_instrumentation_amd64 7.08 MiB 7.12 MiB 2.95 MiB 3.29 MiB
✅ static_quality_gate_docker_cws_instrumentation_arm64 6.69 MiB 6.92 MiB 2.7 MiB 3.07 MiB
✅ static_quality_gate_docker_dogstatsd_amd64 38.63 MiB 39.57 MiB 14.81 MiB 15.76 MiB
✅ static_quality_gate_docker_dogstatsd_arm64 37.26 MiB 38.2 MiB 13.88 MiB 14.83 MiB
✅ static_quality_gate_dogstatsd_deb_amd64 30.58 MiB 31.52 MiB 8.02 MiB 8.97 MiB
✅ static_quality_gate_dogstatsd_deb_arm64 29.14 MiB 30.08 MiB 6.97 MiB 7.92 MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 30.58 MiB 31.52 MiB 8.03 MiB 8.98 MiB
✅ static_quality_gate_dogstatsd_suse_amd64 30.58 MiB 31.52 MiB 8.03 MiB 8.98 MiB
✅ static_quality_gate_iot_agent_deb_amd64 59.87 MiB 60.17 MiB 14.97 MiB 15.82 MiB
✅ static_quality_gate_iot_agent_deb_arm64 56.6 MiB 56.94 MiB 12.85 MiB 13.86 MiB
✅ static_quality_gate_iot_agent_deb_armhf 56.05 MiB 56.41 MiB 12.98 MiB 13.86 MiB
✅ static_quality_gate_iot_agent_rpm_amd64 59.87 MiB 60.18 MiB 15.0 MiB 15.84 MiB
✅ static_quality_gate_iot_agent_rpm_arm64 56.6 MiB 56.94 MiB 12.86 MiB 13.76 MiB
✅ static_quality_gate_iot_agent_suse_amd64 59.87 MiB 60.18 MiB 15.0 MiB 15.84 MiB

@misteriaud misteriaud requested a review from a team as a code owner May 19, 2025 13:04
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels May 19, 2025
@misteriaud misteriaud force-pushed the misteriaud/remove-fips-proxy-status-from-fips-agent branch from d4ac237 to ff798d8 Compare May 21, 2025 16:44
@github-actions github-actions bot added medium review PR review might take time and removed long review PR is complex, plan time to review it labels May 21, 2025
@misteriaud misteriaud added backport/7.67.x Automatically create a backport PR to 7.67.x backport/7.66.x Automatically create a backport PR to 7.66.x labels May 22, 2025
@misteriaud
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-22 16:13:46 UTC ℹ️ Start processing command /merge

2025-05-22 16:14:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-22 16:14:25 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-05-22 16:56:44 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1db6dbe into main May 22, 2025
259 checks passed
@github-actions github-actions bot added this to the 7.68.0 milestone May 22, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request May 22, 2025
@misteriaud @github-actions
[AGENTRUN-310] Remove FIPS Proxy status to FIPS Agent status output (#…
20c70e3 
…36988)

(cherry picked from commit 1db6dbe)
@agent-platform-auto-pr agent-platform-auto-pr bot mentioned this pull request May 22, 2025
Merged
agent-platform-auto-pr bot pushed a commit that referenced this pull request May 22, 2025
@misteriaud @github-actions
[AGENTRUN-310] Remove FIPS Proxy status to FIPS Agent status output (#…
cfdfd36 
…36988)

(cherry picked from commit 1db6dbe)
@agent-platform-auto-pr agent-platform-auto-pr bot mentioned this pull request May 22, 2025
Merged
chouquette pushed a commit that referenced this pull request May 23, 2025
@misteriaud @chouquette
[AGENTRUN-310] Remove FIPS Proxy status to FIPS Agent status output (#…
c90a60b 
…36988)

(cherry picked from commit 1db6dbe)
This was referenced Jun 3, 2025
Merged
Closed
This was referenced Jun 10, 2025
Open
Merged
@misteriaud misteriaud mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hush-hush hush-hush hush-hush approved these changes

@ameske ameske ameske approved these changes

@jeremy-hanna jeremy-hanna jeremy-hanna approved these changes

Assignees
No one assigned
Labels
backport/7.66.x Automatically create a backport PR to 7.66.x backport/7.67.x Automatically create a backport PR to 7.67.x changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@misteriaud @hush-hush @ameske @jeremy-hanna