Fix alias of draft page shows edit form #13210
Open
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.loom.com/share/9dee4dbdc2794dc9a9676df16c0f5d20
If you create an alias from a draft page and then go to edit it, you see the edit form (which the edit form for the source page) instead of the "This is an alias" message.
This is because
page.get_latest_revision_as_object()will return the latest revision as an object. On pages, this is saved onlatest_revision. As aliases cannot have revisions, I've updatedCreatePageAliasActionto excludelatest_revisionNote that this broke somewhere between Wagtail 3.x and 4.x and it was not noticed.
Fixes #13090 and partially #13100