-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Image settings DX tweaks in documentation #13232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thibaudcolas
wants to merge
1
commit into
wagtail:main
Choose a base branch
from
thibaudcolas:image-settings-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Image settings DX tweaks
- Loading branch information
commit 5066b4dda41497aecd7ecfe792a9e927693ccde9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -412,14 +412,47 @@ Custom storage classes should subclass `django.core.files.storage.Storage`. See | |
### `WAGTAILIMAGES_EXTENSIONS` | ||
|
||
```python | ||
WAGTAILIMAGES_EXTENSIONS = ['png', 'jpg'] | ||
WAGTAILIMAGES_EXTENSIONS = ['avif', 'svg'] | ||
``` | ||
|
||
A list of allowed image extensions that will be validated during image uploading. | ||
If this isn't supplied, all of AVIF, GIF, JPG, JPEG, PNG, WEBP are allowed. | ||
Warning: this doesn't always ensure that the uploaded file is valid as files can | ||
be renamed to have an extension no matter what data they contain. | ||
|
||
### `WAGTAILIMAGES_JPEG_QUALITY` | ||
|
||
```python | ||
WAGTAILIMAGES_JPEG_QUALITY = 75 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here and below – I chose to demo the settings with realistic values, that should work on all sorts of sites, and lead to smaller images than our defaults. |
||
``` | ||
|
||
Change the global default for JPEG image encoding quality (default: 85). | ||
|
||
### `WAGTAILIMAGES_WEBP_QUALITY` | ||
|
||
```python | ||
WAGTAILIMAGES_WEBP_QUALITY = 70 | ||
``` | ||
|
||
Change the global default for WebP image encoding quality (default: 80). | ||
|
||
### `WAGTAILIMAGES_AVIF_QUALITY` | ||
|
||
```python | ||
WAGTAILIMAGES_AVIF_QUALITY = 65 | ||
``` | ||
|
||
Change the global default for AVIF image encoding quality (default: 80). | ||
|
||
### `WAGTAILIMAGES_HEIC_QUALITY` | ||
|
||
```python | ||
WAGTAILIMAGES_HEIC_QUALITY = 60 | ||
``` | ||
|
||
Change the global default for HEIC image encoding quality (default: 80). | ||
|
||
|
||
## Documents | ||
|
||
### `WAGTAILDOCS_DOCUMENT_MODEL` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not precious about which extensions we have in there, was just trying to go some way towards avoiding #13127