Refactor output-format related code into a dedicated class + interface #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
reviewed
Jun 3, 2022
Merged
mpdude
added a commit
that referenced
this pull request
Aug 29, 2022
The `DumperTest` class is FUBAR in its design: It mocks the DBAL connection, making assumptions about the order and semantics of the queries the `Dumper` class will issue. As long as we need to query the database for schema information and/or use the DBAL schema tool that does it, probably the only way to go for code like this is to do real functional/integration tests against a real database. Since this broken test is getting in our way in #88, let's remove it.
mpdude
changed the title
mpdude
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are looking into adding an option to do CSV exports as well. As a first step in that direction, we need to separate everything related to how we write export SQL from things related to fetching the data and user interface. Currently, that's all mixed up in the
Dumperclass.This PR takes a first step in that direction by introducing the
OutputFormatDriverInterface, and moving everything related to exporting SQL from theDumperclass toMysqlOutputFormatDriver.