Skip to content

Remove DumperTest #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Remove DumperTest #90

merged 1 commit into from
Aug 29, 2022

Conversation

mpdude
Copy link
Member

@mpdude mpdude commented Aug 29, 2022

The DumperTest class is FUBAR in its design: It mocks the DBAL connection, making assumptions about the order and semantics of the queries the Dumper class will issue.

As long as we need to query the database for schema information and/or use the DBAL schema tool that does it, probably the only way to go for code like this is to do real functional/integration tests against a real database.

Since this broken test is getting in our way in #88, let's remove it.

@mpdude mpdude merged commit d03589e into master Aug 29, 2022
@mpdude mpdude deleted the remove-dumper-test branch August 29, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant