Turn Rotate View dropdown into two buttons #23730
Conversation
|
I am not convinced this should be an option, especially when the drop-down is now gone and there is no button to rotate CW. If it has to be, is prefer to default to on. |
|
I don’t think many people currently use the "rotate anti-clockwise" option, because it’s extraordinarily tedious to use: you have to click and drag to use the dropdown. 3 clicks is much faster and less faff. It is also in line with how most other buttons are optional, even the zoom buttons. |
|
Sprite looks good, code looks clean. Only thing I have to add is I would prefer the buttons were swapped, with CW on the left and CCW on the right. It feels a bit more balanced that way, in my opinion. |
|
Maybe it’s just me, but I think that looks a bit weird:
In any case, I’d appreciate if we could just merge this and forgo the bikeshedding. |
Co-authored-by: MasterTomNL <tomvanderlek@gmail.com>
Gymnasiast
force-pushed
the
feature/two-rotate-buttons-touch
branch
from
f6e5cc1 to
ee0aebf
Compare
To be honest, I think there is something to be said about this order as well. I like that both arrows are pointing 'away' from the current rotation, so to speak. As it is, they both point in the same direction, just from a different angle. Does that make sense? Up to you if you want to change it. Functionally, the PR is fine as-is. |
|
With OpenRCT2-v0.4.18-159-g6f9d317edf-linux-x86_64.AppImage , the drop down on the button is gone, but I have no second rotation button. |
The button is optional, be sure to enable it in your settings. |
Oh, there. Yep, now I have the button too. Sorry about that. |
- Feature: [#23328] Introducing peep animation objects, enabling custom entertainer costumes. - Feature: [#23569] Add large diagonal flat to steep and dive loop track pieces. - Improved: [#20683] Allow Giga Coaster cable lift to start after block brake section. - Improved: [#23328] The costume list in the staff window is now ordered alphabetically. - Improved: [#23540] The file browser now optionally shows a file size column. - Improved: [#23640] Building sprite repository with command line can use images array of JSON parkobj. - Improved: [#23660] The ‘special elements’ dropdown has been reorganised, now using multiple columns and separators. - Improved: [#23730] Added optional button to toolbar to rotate view anti-clockwise. - Change: [#23328] All RCT2 entertainer costumes are now available in legacy parks. - Fix: [#1479] Incorrect values provided by the in game console “get location” command. - Fix: [#21794] Lay-down coaster cars reverse on first frames of downwards corkscrew. - Fix: [#23221] Track designs are saved with an incorrect ‘air’ time statistic. - Fix: [#23368] Incorrect refund amount when deleting track pieces at or above 96m. - Fix: [#23508] Simultaneous virtual floors shown for ride and footpath. - Fix: [#23512] Holding brakes are skipped if they’re too close together. - Fix: [#23581] [Plugin] Food/drink items given to guests have no consumption duration set. - Fix: [#23591] “Install new track” button in Track Designs Manager is misaligned. - Fix: [#23618] Can no longer build diagonal brakes & block brakes on Steeplechase, Inverted Lay-down, & Inverted Multi-Dim roller coasters.
Some years ago, the "Rotate view" button was turned into a dropdown, in order to add a way to rotate anticlockwise. This is awkward enough on desktop, but even worse on touch.
This PR changes the "rotate view" dropdown back to a normal button and just adds a button to rotate anti-clockwise, hidden by default, which should make life better for everyone.
As I loosely based this off a commit from @MasterTomNL, he gets a co-credit.