Skip to content

Add new sprites for snow weather types #23879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Feb 22, 2025

This PR introduces new sprites for the various snow weather types. Previously, all three used the same icon from G1.

Split off from #23774.

Before / after:
climate-types-1 climate-types-2

Co-authored-by: ZeeMaji <42477864+ZeeMaji@users.noreply.github.com>
@AaronVanGeffen AaronVanGeffen added the changelog This issue/PR deserves a changelog entry. label Feb 22, 2025
@Gymnasiast
Copy link
Member

Hm, why did you also replace the regular snow sprite? Generally, I would prefer keeping that original, unless you have a very good reason.

@733737
Copy link
Contributor

733737 commented Feb 22, 2025

I prefer the snowflake greatly to these "flakes"

@AaronVanGeffen
Copy link
Member Author

AaronVanGeffen commented Feb 22, 2025

Hm, why did you also replace the regular snow sprite?

The light snow icon has had its cloud replaced with a lighter colour to better contrast with heavy snow.

I prefer the snowflake greatly to these "flakes"

What do you mean? These are just the weather icons, not the in-game effects.

@733737
Copy link
Contributor

733737 commented Feb 22, 2025

I mean that a stylized large snowflake looks better to me than a few black dots

@AaronVanGeffen
Copy link
Member Author

AaronVanGeffen commented Feb 22, 2025

I mean that a stylized large snowflake looks better to me than a few black dots

That simply hasn't been changed though?? I've added some screenshots to the OP, fwiw.

Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, seeing all of the graphics side-by-side makes it clear.

@Gymnasiast Gymnasiast added this to the v0.4.20 milestone Feb 22, 2025
@733737
Copy link
Contributor

733737 commented Feb 22, 2025

sorry I was wrong, my bad

@AaronVanGeffen AaronVanGeffen enabled auto-merge (squash) February 22, 2025 19:20
@AaronVanGeffen AaronVanGeffen merged commit a8a3432 into OpenRCT2:develop Feb 22, 2025
22 checks passed
@AaronVanGeffen AaronVanGeffen deleted the snow-weather-icons branch February 22, 2025 19:30
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this pull request Feb 25, 2025
- Feature: [OpenRCT2#22905] Add diagonal downward-inclined brakes to hybrid coaster and single rail coaster.
- Feature: [OpenRCT2#23759] Add see-through option to the “Cut-away View“.
- Improved: [OpenRCT2#23677] Building new ride track now inherits the colour scheme from the previous piece.
- Improved: [OpenRCT2#23720] Text fields now allow cutting to clipboard (Ctrl+X) in addition to copy and paste.
- Improved: [OpenRCT2#23874] The load/save file browser window now uses icons for its action buttons.
- Improved: [OpenRCT2#23875] Rides forbidden to be modified or destroyed can now be edited with the All destructible cheat.
- Improved: [OpenRCT2#23879] Unique weather icons for snow, heavy snow and blizzard.
- Fix: [OpenRCT2#1972, OpenRCT2#11679] Vehicles passing by toilets can cause them to glitch (original bug).
- Fix: [OpenRCT2#9999, OpenRCT2#10000, OpenRCT2#10001, OpenRCT2#10002, OpenRCT2#10003] Truncated scenario strings when using Catalan, Czech, Japanese, Polish or Russian.
- Fix: [OpenRCT2#14486] Guests will fall through upwards sloped paths when making their way through a park entrance or ride exit (original bug).
- Fix: [OpenRCT2#15826, OpenRCT2#23835] Wooden Roller Coaster steep turn supports glitch when train goes over them (original bug).
- Fix: [OpenRCT2#16357] Chairlift station covers draw incorrectly.
- Fix: [OpenRCT2#16657] Mine Ride right S-bend uses Mini Roller Coaster sprite (original bug).
- Fix: [OpenRCT2#18376] Ghost train gentle to flat track is not visible in tunnels.
- Fix: [OpenRCT2#18389] Gentle sloped track pieces are not visible in low clearance height tunnels (original bug).
- Fix: [OpenRCT2#18423] Underground Mini Golf holes can draw over land edges (original bug).
- Fix: [OpenRCT2#18433] CJK TrueType fonts cannot be located when font names are translated by the OS.
- Fix: [OpenRCT2#18436] Scenery on the same tile as steep to vertical track can draw over the track (original bug).
- Fix: [OpenRCT2#18711] Park entrances with their sides underground can cause glitching.
- Fix: [OpenRCT2#20848] Junior Roller Coaster booster track does not draw correctly in tunnels.
- Fix: [OpenRCT2#20948] Incorrect diagonal brakes supports on the Giga Coaster, Looping Roller Coaster and Wooden Roller Coaster.
- Fix: [OpenRCT2#21768] Dirty blocks debug overlay is rendered incorrectly on high DPI screens.
- Fix: [OpenRCT2#22229] Opening a park save file from a newer version of OpenRCT2 yields an unhelpful error message.
- Fix: [OpenRCT2#22617] Sloped Wooden and Side-Friction supports draw out of order when built directly above diagonal track pieces (original bug).
- Fix: [OpenRCT2#22620] Mine Train Coaster trains glitch on large banked turns.
- Fix: [OpenRCT2#23522] Diagonal sloped Steeplechase supports have glitched sprites at the base.
- Fix: [OpenRCT2#23580] Table header labels may overlap if the window is made very small.
- Fix: [OpenRCT2#23641] Steep to flat track is not drawn correctly in tunnels (original bug).
- Fix: [OpenRCT2#23795] Looping Roller Coaster vertical loop supports are drawn incorrectly.
- Fix: [OpenRCT2#23797] 3D Text cut off too early on multi-line signs.
- Fix: [OpenRCT2#23809] Trains glitch on Bobsleigh Coaster small helixes.
- Fix: [OpenRCT2#23811] Land edges glitch when vehicles go through gentle to flat tunnels.
- Fix: [OpenRCT2#23814] Scenarios not indexed on first start.
- Fix: [OpenRCT2#23818] Spinning tunnels can draw over sloped terrain in front of them.
- Fix: [OpenRCT2#23828] Vehicles passing by station entrances and exits can cause them to glitch (original bug).
- Fix: [OpenRCT2#23831] Hybrid Coaster large gentle banked right turns glitch when diagonal track is above them.
- Fix: [OpenRCT2#23832] Hybrid Coaster large gentle banked left turns supports glitch as train passes.
- Fix: [OpenRCT2#23836] Adjacent track can draw over large turns (original bug).
- Fix: [OpenRCT2#23858] LSM launched lift hill has a misaligned sprite.
CorySanin added a commit to CorySanin/OpenRCT2 that referenced this pull request Jun 22, 2025
- Feature: [OpenRCT2#22905] Add diagonal downward-inclined brakes to hybrid coaster and single rail coaster.
- Feature: [OpenRCT2#23759] Add see-through option to the “Cut-away View“.
- Improved: [OpenRCT2#23677] Building new ride track now inherits the colour scheme from the previous piece.
- Improved: [OpenRCT2#23720] Text fields now allow cutting to clipboard (Ctrl+X) in addition to copy and paste.
- Improved: [OpenRCT2#23874] The load/save file browser window now uses icons for its action buttons.
- Improved: [OpenRCT2#23875] Rides forbidden to be modified or destroyed can now be edited with the All destructible cheat.
- Improved: [OpenRCT2#23879] Unique weather icons for snow, heavy snow and blizzard.
- Fix: [OpenRCT2#1972, OpenRCT2#11679] Vehicles passing by toilets can cause them to glitch (original bug).
- Fix: [OpenRCT2#9999, OpenRCT2#10000, OpenRCT2#10001, OpenRCT2#10002, OpenRCT2#10003] Truncated scenario strings when using Catalan, Czech, Japanese, Polish or Russian.
- Fix: [OpenRCT2#14486] Guests will fall through upwards sloped paths when making their way through a park entrance or ride exit (original bug).
- Fix: [OpenRCT2#15826, OpenRCT2#23835] Wooden Roller Coaster steep turn supports glitch when train goes over them (original bug).
- Fix: [OpenRCT2#16357] Chairlift station covers draw incorrectly.
- Fix: [OpenRCT2#16657] Mine Ride right S-bend uses Mini Roller Coaster sprite (original bug).
- Fix: [OpenRCT2#18376] Ghost train gentle to flat track is not visible in tunnels.
- Fix: [OpenRCT2#18389] Gentle sloped track pieces are not visible in low clearance height tunnels (original bug).
- Fix: [OpenRCT2#18423] Underground Mini Golf holes can draw over land edges (original bug).
- Fix: [OpenRCT2#18433] CJK TrueType fonts cannot be located when font names are translated by the OS.
- Fix: [OpenRCT2#18436] Scenery on the same tile as steep to vertical track can draw over the track (original bug).
- Fix: [OpenRCT2#18711] Park entrances with their sides underground can cause glitching.
- Fix: [OpenRCT2#20848] Junior Roller Coaster booster track does not draw correctly in tunnels.
- Fix: [OpenRCT2#20948] Incorrect diagonal brakes supports on the Giga Coaster, Looping Roller Coaster and Wooden Roller Coaster.
- Fix: [OpenRCT2#21768] Dirty blocks debug overlay is rendered incorrectly on high DPI screens.
- Fix: [OpenRCT2#22229] Opening a park save file from a newer version of OpenRCT2 yields an unhelpful error message.
- Fix: [OpenRCT2#22617] Sloped Wooden and Side-Friction supports draw out of order when built directly above diagonal track pieces (original bug).
- Fix: [OpenRCT2#22620] Mine Train Coaster trains glitch on large banked turns.
- Fix: [OpenRCT2#23522] Diagonal sloped Steeplechase supports have glitched sprites at the base.
- Fix: [OpenRCT2#23580] Table header labels may overlap if the window is made very small.
- Fix: [OpenRCT2#23641] Steep to flat track is not drawn correctly in tunnels (original bug).
- Fix: [OpenRCT2#23795] Looping Roller Coaster vertical loop supports are drawn incorrectly.
- Fix: [OpenRCT2#23797] 3D Text cut off too early on multi-line signs.
- Fix: [OpenRCT2#23809] Trains glitch on Bobsleigh Coaster small helixes.
- Fix: [OpenRCT2#23811] Land edges glitch when vehicles go through gentle to flat tunnels.
- Fix: [OpenRCT2#23814] Scenarios not indexed on first start.
- Fix: [OpenRCT2#23818] Spinning tunnels can draw over sloped terrain in front of them.
- Fix: [OpenRCT2#23828] Vehicles passing by station entrances and exits can cause them to glitch (original bug).
- Fix: [OpenRCT2#23831] Hybrid Coaster large gentle banked right turns glitch when diagonal track is above them.
- Fix: [OpenRCT2#23832] Hybrid Coaster large gentle banked left turns supports glitch as train passes.
- Fix: [OpenRCT2#23836] Adjacent track can draw over large turns (original bug).
- Fix: [OpenRCT2#23858] LSM launched lift hill has a misaligned sprite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This issue/PR deserves a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants