Make title bar bigger in Enlarged UI mode #23590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gymnasiast
force-pushed
the
feature/touch-mode-2
branch
2 times, most recently
from
598b4d7 to
c2aa949
Compare
Gymnasiast
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gymnasiast
force-pushed
the
feature/touch-mode-2
branch
2 times, most recently
from
c563db9 to
cb36e98
Compare
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
cb36e98 to
a46b505
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
a46b505 to
9fe2248
Compare
Merged
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
9fe2248 to
2327ec5
Compare
|
Refit the code to make more efficient use of the foundations laid by On a side note, I think we should just fold Below is a screencast of what the PR looks like in its current state. Screen.Recording.2025-03-01.at.15.39.11.mp4 |
Gymnasiast
commented
Mar 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
76a218f to
ffa1ec6
Compare
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
174b5c9 to
8e7eafc
Compare
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
e38a9d2 to
e147cf2
Compare
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
e147cf2 to
dcddb54
Compare
This comment was marked as resolved.
This comment was marked as resolved.
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
fd0cb32 to
c915ef6
Compare
Comment on lines
+987
to
+998
| // Not sure why plugin windows have to be treated differently, | ||
| // but they currently show a deviation if we don't. | ||
| if (w.classification == WindowClass::Custom) | ||
| { | ||
| w.min_height += w.getTitleBarDiffTarget(); | ||
| w.max_height += w.getTitleBarDiffTarget(); | ||
| } | ||
| else | ||
| { | ||
| w.min_height += w.getTitleBarDiffNormal(); | ||
| w.max_height += w.getTitleBarDiffNormal(); | ||
| } |
There was a problem hiding this comment.
This distinction has me stumped. If leave just the else block, however, plugin windows will look off. Conversely, if I leave just the other block, in-game windows like Park and NewRide will look slightly too short.
It works fine, this way, but yes, it has me stumped.
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
f177a51 to
6884495
Compare
Gymnasiast
commented
Apr 17, 2025
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
2 times, most recently
from
fa3f6b4 to
0509091
Compare
AaronVanGeffen
force-pushed
the
feature/touch-mode-2
branch
from
0509091 to
cd286c8
Compare
AaronVanGeffen
approved these changes
Apr 17, 2025
|
The hydra has been vanquished! 🙌 |
AaronVanGeffen
added a commit
that referenced
this pull request
May 4, 2025
- Feature: [#24206] [Plugin] Add APIs for breaking down rides, reading the current breakdown, and for fixing broken down rides. - Improved: [#20073] The OpenGL drawing engine now supports screen invalidation which avoids the redrawing of unchanged regions. - Improved: [#21767] RCT Classic for macOS can now be used as the source game. - Improved: [#23590] Title bars are now drawn bigger when “Enlarged UI” is enabled. - Improved: [#23626] Add small, medium and large flat and sloped turns, S-bends and diagonal track to the Go-Karts. - Improved: [#23982] The scenario objective window has been merged into the scenario options window. - Improved: [#24233] RCT Classic+ from Apple Arcade can now be used as the source game, and is detected automatically. - Improved: [#24260] Better performance on parks that have a lot of Guests and Entertainers. - Improved: [#24319] RCT Classic installs via Steam are now detected automatically on Windows. - Change: [#23803] Lightning strikes and thunder now happen at the same frequency independently of the game speed. - Change: [#23857] Replace display options tab with custom sprites. - Change: [#24069] [Plugin] Plugins are now available in the scenario editor and track designer. - Change: [#24135] Compress Emscripten js/wasm files. - Change: [#24194] The advanced options tab has been reworked to make it easier to find the RCT1 path setting. - Change: [#24235] Small changes to RCT1 theme. - Change: [#24236] Controls and Interface options now both have their own tabs in the Options window. - Change: [#24308] “Software” and “Software (hardware display)” renderers have been merged into a single “Software” renderer. - Change: [#24317] The scenery window now shows at least one row of scenery objects, even if there are multiple rows of tabs. - Fix: [#18479] Tile elements ordered beneath water do not draw correctly. - Fix: [#19782] Game stops counting inversions and golf holes after 31 (original bug). - Fix: [#21207] Track List window gets positioned incorrectly. - Fix: [#21919] Non-recolourable cars still show colour picker (original bug). - Fix: [#22182] [Plugin] Crash when using map.getAllEntities("car"). - Fix: [#22634] Asset packs with sound effect overrides are not loaded correctly at startup. - Fix: [#23108] Missing pieces on Hypercoaster and Hyper-Twister, even with the ‘all drawable track pieces’ cheat enabled. - Fix: [#24013] Failure to load a scenario preview image (minimap) could lead to an uncaught exception error message. - Fix: [#24045] [Plugin] Data storage is not cleared when converting save game to scenario. - Fix: [#24121] Checkbox labels run beyond the edge of the window if they’re too long to fit. - Fix: [#24142] [Plugin] Track origin is miscalculated on downward slopes. - Fix: [#24220] Narrow station platforms have missing sides on certain rotations. - Fix: [#24286] Steam installs of RCT1 and RCT2 are not autodetected on macOS. - Fix: [#24310] [Plugin] Missing invalidation on various plugin api setters for entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our window system being old and clunky, this required quite a lot of refactoring, mostly to replace coordinates being calculated from the topleft of the window with calculating them from the top left of the window body instead. Also splits the title bar and window body height, as windows have no good way of determining their full height in advance - and frankly, how big or small the title bars are is more of a concern to the window manager than to the window itself anyway.
Screen.Recording.2025-03-01.at.15.39.11.mp4